deployment: add context lint rules #15413
Merged
+266
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
chudilka1
force-pushed
the
deployment-lint-context
branch
9 times, most recently
from
8d738b5 to
49634f6
Compare
jmank88
commented
Nov 26, 2024
chudilka1
force-pushed
the
deployment-lint-context
branch
18 times, most recently
from
5d969e2 to
09e67dc
Compare
RensR
previously approved these changes
Dec 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…ctly upload reports Update golangci-lint action to go through all dirs if no working directory set Update paths to linter reports Restore producing test coverage report for each unit test run Remove test files fail_test.go and polished the workflows Get list of affected files Map affected files to modules Update lint working directory for uploading step Update lint working directory for uploading step Removed duplicated runs of golangci-lint Move running tests for core/scripts module to ci-core.yaml workflow Remove test files Move validation of golangci results to a non-matrix job Add filter for affected files in core/scripts. Move related tests to a separate job Update SonarQube to pick up coverage reports for core/scripts test runs
chudilka1
dismissed stale reviews from RensR, krehermann, Atrax1, and themself
via
7ba33dc
chudilka1
force-pushed
the
deployment-lint-context
branch
from
d037ce6 to
7ba33dc
Compare
chudilka1
approved these changes
Dec 18, 2024
RensR
approved these changes
Dec 18, 2024
|
kalverra
requested changes
Dec 18, 2024
| filters: | | ||
| non-integration-tests: | ||
| - '**' | ||
| - '!integration-tests/**' | ||
| non-ignored: | ||
| - '**' | ||
| - '!docs/**' |
There was a problem hiding this comment.
Why remove this? This will include docs/** in changes to NOT ignore I think?
There was a problem hiding this comment.
There are files under docs/ which are read by go source code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deploymentmodule.golangci-lint-actionrun in all the affected modules and upload the corresponding reports.ci-scripts.yml(lint and tests) forcore/scriptsmoved to theci-core.ymlworkflow.