Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialization for Crib #15501

Merged
merged 30 commits into from
Dec 13, 2024
Merged

Initialization for Crib #15501

merged 30 commits into from
Dec 13, 2024

Conversation

0xAustinWang
Copy link
Contributor

@0xAustinWang 0xAustinWang commented Dec 4, 2024 •
edited
Loading

@0xAustinWang 0xAustinWang requested review from a team as code owners December 4, 2024 12:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@0xAustinWang 0xAustinWang requested a review from a team as a code owner December 5, 2024 14:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Flakeguard Summary

Setting Value
Project github.com/smartcontractkit/chainlink/deployment/deployment
Max Pass Ratio 100.00%
Test Run Count 9
Race Detection false
Excluded Tests TestAddLane

Found Flaky Tests ❌

Category Total
Tests 21
Panicked Tests 0
Raced Tests 0
Flaky Tests 1
Flaky Test Ratio 4.76%
Runs 60
Passes 57
Failures 3
Skips 3
Pass Ratio 95.00%
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestAcceptAllOwnership 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/keystone/changeset false 800ms Unknown

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Flakeguard Summary

Setting Value
Project github.com/smartcontractkit/chainlink/deployment/deployment
Max Pass Ratio 100.00%
Test Run Count 9
Race Detection false
Excluded Tests TestAddLane

Found Flaky Tests ❌

Category Total
Tests 21
Panicked Tests 0
Raced Tests 0
Flaky Tests 1
Flaky Test Ratio 4.76%
Runs 60
Passes 57
Failures 3
Skips 3
Pass Ratio 95.00%
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestAcceptAllOwnership 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/keystone/changeset false 646.666666ms Unknown

@smartcontractkit smartcontractkit deleted a comment from github-actions bot Dec 6, 2024
@0xAustinWang 0xAustinWang marked this pull request as draft December 9, 2024 14:25
@0xAustinWang 0xAustinWang requested a review from a team as a code owner December 11, 2024 09:38
@0xAustinWang 0xAustinWang requested a review from aareet December 11, 2024 09:38
@0xAustinWang 0xAustinWang changed the title Aw/crib setup Initialization for Crib Dec 11, 2024
scheibinger
scheibinger previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@scheibinger scheibinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in crib staging env and that fully worked 🎉

b-gopalswami
b-gopalswami previously approved these changes Dec 11, 2024
View reviewed changes
deployment/environment/devenv/don.go
Ocr2KeyBundleID: ocr2BundleId,
Ocr2Plugins: `{"commit":true,"execute":true,"median":false,"mercury":false}`,

// retry twice with 5 seconds interval to create JobDistributorChainConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update comment per retry interval

@0xAustinWang 0xAustinWang added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
AnieeG
AnieeG reviewed Dec 11, 2024
View reviewed changes
deployment/ccip/changeset/cs_home_chain.go Outdated Show resolved Hide resolved
deployment/environment/devenv/don.go Outdated
return "", fmt.Errorf("Could not list job distrubutors: %w", err)
}
if len(resp.FeedsManagers.Results) > 0 {
return resp.FeedsManagers.Results[0].FeedsManagerParts.GetId(), nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be updated to check if the csakey matches with the JD, it should not just return the first one in the result

AnieeG
AnieeG requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@AnieeG AnieeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting change for the update of JD

@0xAustinWang 0xAustinWang requested a review from AnieeG December 12, 2024 08:36
@0xAustinWang 0xAustinWang added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@0xAustinWang 0xAustinWang added this pull request to the merge queue Dec 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 13, 2024
@0xAustinWang 0xAustinWang added this pull request to the merge queue Dec 13, 2024
Merged via the queue into develop with commit 8f1b956 Dec 13, 2024
190 checks passed
@0xAustinWang 0xAustinWang deleted the aw/cribSetup branch December 13, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-gopalswami b-gopalswami b-gopalswami approved these changes

@0xnogo 0xnogo 0xnogo approved these changes

@AnieeG AnieeG AnieeG approved these changes

@makramkd makramkd makramkd approved these changes

@scheibinger scheibinger scheibinger left review comments

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara is a code owner automatically assigned from smartcontractkit/ccip-offchain

@aareet aareet Awaiting requested review from aareet aareet is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0xAustinWang @scheibinger @makramkd @AnieeG @0xnogo @b-gopalswami