Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflows/syncer): check that no engine is running before registering new one #15574

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

MStreet3
Copy link
Contributor

@MStreet3 MStreet3 commented Dec 9, 2024

Checks that no engine is running before registering a new one in the handler.

Requires

#15519

Supports

@MStreet3 MStreet3 requested a review from a team as a code owner December 9, 2024 17:23
Copy link
Contributor

github-actions bot commented Dec 9, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@MStreet3 MStreet3 changed the base branch from develop to cappl-263/skip-fetch-on-missing-urls December 9, 2024 17:37
@MStreet3 MStreet3 requested review from a team as code owners December 9, 2024 17:37
@MStreet3 MStreet3 requested review from vyzaldysanchez, winder, rstout, asoliman92, makramkd, dimkouv, mateusz-sekara and b-gopalswami and removed request for a team December 9, 2024 17:37
@MStreet3 MStreet3 changed the base branch from cappl-263/skip-fetch-on-missing-urls to develop December 9, 2024 17:37
@MStreet3 MStreet3 force-pushed the cappl-351/register-pre-check branch 2 times, most recently from aff4116 to 25d3c66 Compare December 9, 2024 21:16
@MStreet3 MStreet3 force-pushed the cappl-351/register-pre-check branch 3 times, most recently from 5845a0b to ace750f Compare December 10, 2024 17:47
@MStreet3 MStreet3 enabled auto-merge December 10, 2024 17:47
justinkaseman
justinkaseman previously approved these changes Dec 10, 2024
patrickhuie19
patrickhuie19 previously approved these changes Dec 10, 2024
Copy link
Contributor

@patrickhuie19 patrickhuie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but would prefer to use services.Service

@MStreet3 MStreet3 added this pull request to the merge queue Dec 10, 2024
@MStreet3 MStreet3 removed this pull request from the merge queue due to a manual request Dec 10, 2024
@MStreet3 MStreet3 dismissed stale reviews from patrickhuie19 and justinkaseman via 261dd6a December 10, 2024 19:59
@MStreet3 MStreet3 enabled auto-merge December 10, 2024 19:59
@MStreet3 MStreet3 force-pushed the cappl-351/register-pre-check branch from 261dd6a to 044a707 Compare December 10, 2024 20:00
patrickhuie19
patrickhuie19 previously approved these changes Dec 10, 2024
@MStreet3 MStreet3 force-pushed the cappl-351/register-pre-check branch from d4a75c8 to 3f92a1a Compare December 10, 2024 20:06
@MStreet3 MStreet3 added this pull request to the merge queue Dec 10, 2024
Merged via the queue into develop with commit b5e3d9f Dec 10, 2024
169 of 170 checks passed
@MStreet3 MStreet3 deleted the cappl-351/register-pre-check branch December 10, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants