-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(workflows/syncer): check that no engine is running before registering new one #15574
Merged
+133
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
MStreet3
changed the base branch from
develop
to
cappl-263/skip-fetch-on-missing-urls
December 9, 2024 17:37
MStreet3
requested review from
vyzaldysanchez,
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
b-gopalswami
and removed request for
a team
December 9, 2024 17:37
MStreet3
changed the base branch from
cappl-263/skip-fetch-on-missing-urls
to
develop
December 9, 2024 17:37
cedric-cordenier
previously approved these changes
Dec 9, 2024
MStreet3
force-pushed
the
cappl-351/register-pre-check
branch
2 times, most recently
from
December 9, 2024 21:16
aff4116
to
25d3c66
Compare
MStreet3
force-pushed
the
cappl-351/register-pre-check
branch
3 times, most recently
from
December 10, 2024 17:47
5845a0b
to
ace750f
Compare
cedric-cordenier
previously approved these changes
Dec 10, 2024
MStreet3
force-pushed
the
cappl-351/register-pre-check
branch
from
December 10, 2024 18:23
ace750f
to
60be59d
Compare
justinkaseman
previously approved these changes
Dec 10, 2024
patrickhuie19
previously approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but would prefer to use services.Service
MStreet3
dismissed stale reviews from patrickhuie19 and justinkaseman
via
December 10, 2024 19:59
261dd6a
MStreet3
force-pushed
the
cappl-351/register-pre-check
branch
from
December 10, 2024 20:00
261dd6a
to
044a707
Compare
patrickhuie19
previously approved these changes
Dec 10, 2024
MStreet3
force-pushed
the
cappl-351/register-pre-check
branch
from
December 10, 2024 20:02
044a707
to
d4a75c8
Compare
MStreet3
force-pushed
the
cappl-351/register-pre-check
branch
from
December 10, 2024 20:06
d4a75c8
to
3f92a1a
Compare
justinkaseman
approved these changes
Dec 10, 2024
patrickhuie19
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks that no engine is running before registering a new one in the handler.
Requires
#15519
Supports