[DEVSVCS-963] Ensure that workflow id is unique #15582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
eutopian
force-pushed
the
DEVSVCS-963/unique-workflowid
branch
3 times, most recently
from
4778956 to
f908103
Compare
|
@eutopian code looks good, I have two additional comments to add:
|
cedric-cordenier
previously approved these changes
Dec 10, 2024
eutopian
force-pushed
the
DEVSVCS-963/unique-workflowid
branch
2 times, most recently
from
d93c1b2 to
02ab7af
Compare
DeividasK
reviewed
Dec 10, 2024
Comment on lines
538
to
544
| /// @notice Frees up a previously used workflowID, allowing it to be reused. | ||
| /// @param workflowID The workflowID to release. | ||
| function _releaseWorkflowID( | ||
| bytes32 workflowID | ||
| ) internal { | ||
| s_workflowIDs[workflowID] = false; | ||
| } |
There was a problem hiding this comment.
I don't think this needs a separate function and could just be done inline for readability purposes.
eutopian
force-pushed
the
DEVSVCS-963/unique-workflowid
branch
from
d66b0e6 to
c561b73
Compare
eutopian
force-pushed
the
DEVSVCS-963/unique-workflowid
branch
from
c561b73 to
d4224b3
Compare
ibrajer
approved these changes
Dec 10, 2024
DeividasK
approved these changes
Dec 11, 2024
| @@ -138,6 +138,35 @@ contract WorkflowRegistry_registerWorkflow is WorkflowRegistrySetup { | |||
| ); | |||
| } | |||
|
|
|||
| // whenTheCallerIsAnAuthorizedAddress whenTheRegistryIsNotLocked whenTheDonIDIsAllowed | |||
| function test_RevertWhen_TheWorkflowIDIsAlreadyInUsedByAnotherWorkflow() external { | |||
There was a problem hiding this comment.
Suggested change
| function test_RevertWhen_TheWorkflowIDIsAlreadyInUsedByAnotherWorkflow() external { | |
| function test_RevertWhen_TheWorkflowIDIsAlreadyInUseByAnotherWorkflow() external { |
typo
Comment on lines
+302
to
+303
| // Ensure the new workflowID is unique | ||
| _requireUniqueWorkflowID(newWorkflowID); |
There was a problem hiding this comment.
This is redundant because above you have:
// Condition to revert: WorkflowID must change, and at least one URL must change
if (currentWorkflowID == newWorkflowID) {
revert WorkflowIDNotUpdated();
}
Now you still need to do the newWorkflowID != address(0) check, but you might be better off inlining it as it isn't quite "requireUnique".
There was a problem hiding this comment.
We should remove the current == old then as we still need to check globally it's unique in case it's a different but existing workflowID
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports