Add remaining CCIP views #15590
Merged
Add remaining CCIP views #15590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
connorwstein
commented
Dec 10, 2024
•
connorwstein
commented
- Basic views for CCIPHome and 1.5 ramps
- Remove old ccip_config
- Excluding token pool views for a follow up
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
AnieeG
reviewed
Dec 10, 2024
| @@ -117,8 +121,6 @@ type CCIPChainState struct { | |||
| CapabilityRegistry *capabilities_registry.CapabilitiesRegistry | |||
| CCIPHome *ccip_home.CCIPHome | |||
| RMNHome *rmn_home.RMNHome | |||
| // TODO remove once staging upgraded. | |||
| CCIPConfig *ccip_config.CCIPConfig | |||
There was a problem hiding this comment.
Can you also remove CommitStore ? We need to anyway include it in LegacyState
There was a problem hiding this comment.
I think will be easy to just move to the new struct
AnieeG
approved these changes
Dec 10, 2024
AnieeG
approved these changes
Dec 10, 2024
makramkd
approved these changes
Dec 11, 2024
matYang
approved these changes
Dec 11, 2024
connorwstein
deleted the
CCIP-3047-pre-testnet-define-ccipv-2-state-representation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.