Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logs to ccip launcher for when nodes are starting up #15608

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

0xAustinWang
Copy link
Contributor

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Dec 10, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , Core Tests (go_core_tests) , lint , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakey Test Detection , SonarQube Scan

1. Test_launcher_processDiff failed: [Run tests]

Source of Error:
ccip_oracle.go:119: FAIL: Start()
	at: [/home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher_test.go:684 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher_test.go:759 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher_test.go:678]
ccip_oracle.go:119: FAIL: 0 out of 1 expectation(s) were met.
	The code you are testing needs to make 1 more call(s).
	at: [/home/runner/work/chainlink/chainlink/core/capabilities/ccip/types/mocks/ccip_oracle.go:119 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1176 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1354 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1627 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1635 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/runtime/panic.go:785 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/runtime/panic.go:262 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/runtime/signal_unix.go:917 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher.go:304 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher.go:191 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher_test.go:739]

Why: The test Test_launcher_processDiff failed because the expected call to Start() was not made. The mock expectation was not met, indicating that the code under test did not invoke the Start() method as anticipated.

Suggested fix: Ensure that the Start() method is called within the processDiff function in the launcher package. Verify the logic flow to ensure the method is invoked under the correct conditions.

2. Create method failed: [Run tests]

Source of Error:
oracle_creator.go:139: FAIL: Create(string,string,mock.argumentMatcher)
	at: [/home/runner/work/chainlink/chainlink/core/capabilities/ccip/types/mocks/oracle_creator.go:65 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher_test.go:685 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher_test.go:759 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher_test.go:678]
oracle_creator.go:139: FAIL: 0 out of 2 expectation(s) were met.
	The code you are testing needs to make 2 more call(s).
	at: [/home/runner/work/chainlink/chainlink/core/capabilities/ccip/types/mocks/oracle_creator.go:139 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1176 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1354 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1627 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1635 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/runtime/panic.go:785 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/runtime/panic.go:262 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/runtime/signal_unix.go:917 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher.go:304 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher.go:191 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher_test.go:739]

Why: The test failed because the Create method was expected to be called twice, but it was not called at all. This indicates that the code under test did not invoke the Create method as expected.

Suggested fix: Ensure that the Create method is called the expected number of times within the relevant function. Check the logic to confirm that the conditions for calling Create are met.

3. GetOCRConfigs method failed: [Run tests]

Source of Error:
home_chain_reader.go:126: FAIL: GetOCRConfigs(string,uint32,uint8)
	at: [/home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher_test.go:643 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher_test.go:759 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher_test.go:640]
home_chain_reader.go:126: FAIL: 0 out of 2 expectation(s) were met.
	The code you are testing needs to make 2 more call(s).
	at: [/home/runner/work/chainlink/chainlink/core/capabilities/ccip/types/mocks/home_chain_reader.go:126 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1176 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1354 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1627 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1635 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/runtime/panic.go:785 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/runtime/panic.go:262 /home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/runtime/signal_unix.go:917 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher.go:304 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher.go:191 /home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher_test.go:739]

Why: The test failed because the GetOCRConfigs method was expected to be called twice, but it was not called at all. This indicates that the code under test did not invoke the GetOCRConfigs method as expected.

Suggested fix: Ensure that the GetOCRConfigs method is called the expected number of times within the relevant function. Verify the logic to confirm that the conditions for calling GetOCRConfigs are met.

4. Runtime error: invalid memory address or nil pointer dereference: [Run tests]

Source of Error:
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x90 pc=0x1dbbc3b]

goroutine 19892 [running]:
testing.tRunner.func1.2({0x2ca2740, 0x4bad5b0})
	/home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1632 +0x230
testing.tRunner.func1()
	/home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1635 +0x35e
panic({0x2ca2740?, 0x4bad5b0?})
	/home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/runtime/panic.go:785 +0x132
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/launcher.(*launcher).processRemoved(0xc000d9d8c0, 0xc001449710)
	/home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher.go:304 +0x1fb
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/launcher.(*launcher).processDiff(0xc000d9d8c0, {0x36e62f0, 0xc00134a7e0}, {0x0?, 0xc001449710?, 0x0?})
	/home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher.go:191 +0x45
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/launcher.Test_launcher_processDiff.func20(0xc001331040)
	/home/runner/work/chainlink/chainlink/core/capabilities/ccip/launcher/launcher_test.go:739 +0x195
testing.tRunner(0xc001331040, 0xc0011df8e0)
	/home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1690 +0xf4
created by testing.(*T).Run in goroutine 19891
	/home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.4.linux-amd64/src/testing/testing.go:1743 +0x390

Why: The test encountered a runtime error due to an invalid memory address or nil pointer dereference. This indicates that the code attempted to access a memory location that was not initialized or was nil.

Suggested fix: Check the processRemoved and processDiff methods in the launcher package to ensure that all pointers are properly initialized before use. Add nil checks where necessary to prevent dereferencing nil pointers.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants