Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor workflow registry to use querykeys api #15638

Merged
merged 13 commits into from
Dec 12, 2024
Merged

Refactor workflow registry to use querykeys api #15638

merged 13 commits into from
Dec 12, 2024

Conversation

ettec
Copy link
Collaborator

@ettec ettec commented Dec 11, 2024

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@ettec ettec marked this pull request as ready for review December 11, 2024 17:12
@ettec ettec requested review from a team as code owners December 11, 2024 17:12
@ettec ettec requested a review from patrickhuie19 December 11, 2024 17:12
george-dorin
george-dorin previously approved these changes Dec 12, 2024
View reviewed changes
@ettec ettec dismissed stale reviews from george-dorin and cedric-cordenier via 388b658 December 12, 2024 12:57
@ettec ettec requested a review from a team as a code owner December 12, 2024 12:57
agparadiso
agparadiso previously approved these changes Dec 12, 2024
View reviewed changes
ettec added 12 commits December 12, 2024 14:53
@ettec
temp disable test
c6c8ce2
@ettec
wip
8220556
@ettec
fix duplicate event bug - change contract reader poll query from Gte …
350db87 
…to Gt
@ettec
event state sync test added and passing with fixes - single event
0df1496
@ettec
added methods to create different event types
99b19b2
@ettec
pre-refactor checkpoint - up to this commit no changes have been made…
91de156 
… to wf registry - test has been added to confirm (and actually has found bugs) in current wf registry behaviour
@ettec
refactor part 1: replaced querykey with querykeys - all tests passing
f118eed
@ettec
refactor part 2: collapse individual event query into single events q…
4d82e96 
…uery and reduce goroutine and channel usage
@ettec
refactor part 3 - down to single ticker thread
527f804
@ettec
tidy
7f71176
@ettec
enable the event ordering test that was failing in the old workflow s…
02acd30 
…yncer
@ettec
lint
16b1e57 
remove change to try and resolve flaky eth smoke tests
@ettec ettec force-pushed the refactor-workflow-registry-to-use-querykeys branch from f5b532f to 16b1e57 Compare December 12, 2024 14:58
@ettec ettec enabled auto-merge December 12, 2024 16:04
@ettec ettec added this pull request to the merge queue Dec 12, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 12, 2024
@ettec
Refactor workflow registry to use querykeys api (#15638)
fac0569 
* temp disable test

* wip

* fix duplicate event bug - change contract reader poll query from Gte to Gt

* event state sync test added and passing with fixes - single event

* added methods to create different event types

* pre-refactor checkpoint - up to this commit no changes have been made to wf registry - test has been added to confirm (and actually has found bugs) in current wf registry behaviour

* refactor part 1:  replaced querykey with querykeys - all tests passing

* refactor part 2: collapse individual event query into single events query and reduce goroutine and channel usage

* refactor part 3 - down to single ticker thread

* tidy

* enable the event ordering test that was failing in the old workflow syncer

* lint

remove change to try and resolve flaky eth smoke tests

* log fix
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@ettec ettec added this pull request to the merge queue Dec 12, 2024
Merged via the queue into develop with commit 83f7413 Dec 12, 2024
169 of 170 checks passed
@ettec ettec deleted the refactor-workflow-registry-to-use-querykeys branch December 12, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@george-dorin george-dorin george-dorin approved these changes

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@agparadiso agparadiso agparadiso approved these changes

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19 patrickhuie19 is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ettec @agparadiso @cedric-cordenier @george-dorin