-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: install toolchain version #15645
Conversation
I see you updated files related to
|
IMHO we need to find a way to work with the tooling, not against it. This is an important feature for reproducability, and disallowing it can suddenly become a problem that surprises us later. |
Can we install the correct version if we read the toolchain first?
|
AFAICT there's not a great solution to this. Is it possible that we keep the go version in sync with the desired toolchain version, then remove the toolchain directive? What's the benefit of having a different go and toolchain versions? I don't know if there's subtleties, but it seems unnecessary. |
As you suggested, here is a workaround that gets the toolchain version, and installs that instead. actions/setup-go#457 (comment)
|
69b478e
to
acd2f55
Compare
acd2f55
to
b02e674
Compare
Changes
toolchain
directive if it exists.Motivation
This is the cause for the errors seen during go mod cache restores for all of our workflows.
Basically the
actions/setup-go
action doesn't install the provided toolchain version, so when executing ago
command later, it fetches the toolchain version and adds the toolchain's modules to the go mod cache. When we go to restore the cache, it can't overwrite the modules which are already present.Related: actions/setup-go#424
RE-3325