deployment/ccip/changeset: mcms optional ccip home cses #15658
Conversation
Add MCMS optionality for the rest of the CCIPHome changesets, and organize things a little bit better by moving the AddDON changeset into cs_ccip_home.go out of cs_add_chain.go
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
|
|
||
| PluginType types.PluginType | ||
| NodeIDs []string | ||
| CCIPOCRParams CCIPOCRParams |
There was a problem hiding this comment.
This is a little awkward where pluginType will determine which field in CCIPOCRParams is used. Probably won't be super easy to refactor but lets add a clear comment
There was a problem hiding this comment.
I had the same thought when I was writing this, was considering just passing in the full OCR3Config instead of constructing it within the CS. WDYT?
| return nil, fmt.Errorf("get node info: %w", err) | ||
| } | ||
|
|
||
| // TODO: validate token config |
There was a problem hiding this comment.
might be easier to track if we keep mentioning tickets for todos
There was a problem hiding this comment.
Good point, will create tickets
| return deployment.ChangesetOutput{}, fmt.Errorf("missing commit plugin in ocr3Configs") | ||
| } | ||
|
|
||
| expectedDonID := latestDon.Id + 1 |
There was a problem hiding this comment.
we'll need to find a way to prevent running a AddDonAndSetCandidateChangeset until the previous one is fully executed otherwise you can have 2 with the same expectedDonID. For now lets add a super loud comment on the CS definition
There was a problem hiding this comment.
can we include a parameter for expected donID ? we can include the internal.LatestCCIPDON in view to get the value externally
There was a problem hiding this comment.
we'll need to find a way to prevent running a AddDonAndSetCandidateChangeset until the previous one is fully executed otherwise you can have 2 with the same expectedDonID
Yeah, had a similar thought, not sure of the best way to make this bullet proof.
There was a problem hiding this comment.
lets address in a follow up
| return deployment.ChangesetOutput{}, fmt.Errorf("missing commit plugin in ocr3Configs") | ||
| } | ||
|
|
||
| expectedDonID := latestDon.Id + 1 |
There was a problem hiding this comment.
can we include a parameter for expected donID ? we can include the internal.LatestCCIPDON in view to get the value externally
Add MCMS optionality for the rest of the CCIPHome changesets, and organize things a little bit better by moving the AddDON changeset into cs_ccip_home.go out of cs_add_chain.go
Requires
Supports