Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt fix for duplicate metrics collector error #15663

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Attempt fix for duplicate metrics collector error #15663

merged 2 commits into from
Dec 13, 2024

Conversation

samsondav
Copy link
Collaborator

Requires

Supports

@samsondav samsondav added build-test-image Will build the e2e test image in integration-tests workflow for PRs release-preview build-publish Build and Publish image to SDLC labels Dec 12, 2024
@msuchacz-cll msuchacz-cll added build-test-image Will build the e2e test image in integration-tests workflow for PRs and removed build-test-image Will build the e2e test image in integration-tests workflow for PRs release-preview labels Dec 12, 2024
@samsondav samsondav force-pushed the hotfix_prom_metrics_duplicate_metrics_collector branch from 19bb510 to c1e81ee Compare December 12, 2024 14:59
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@samsondav samsondav force-pushed the hotfix_prom_metrics_duplicate_metrics_collector branch from c1e81ee to d6d07d7 Compare December 12, 2024 15:08
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@samsondav samsondav force-pushed the hotfix_prom_metrics_duplicate_metrics_collector branch from d6d07d7 to 893a34c Compare December 12, 2024 19:37
@samsondav samsondav marked this pull request as ready for review December 12, 2024 21:21
@samsondav samsondav requested review from a team as code owners December 12, 2024 21:21
@samsondav samsondav enabled auto-merge December 13, 2024 00:05
@samsondav samsondav added this pull request to the merge queue Dec 13, 2024
Merged via the queue into develop with commit 7ca4930 Dec 13, 2024
169 of 170 checks passed
@samsondav samsondav deleted the hotfix_prom_metrics_duplicate_metrics_collector branch December 13, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msuchacz-cll msuchacz-cll msuchacz-cll approved these changes

@jmank88 jmank88 jmank88 approved these changes

Assignees
No one assigned
Labels
build-publish Build and Publish image to SDLC build-test-image Will build the e2e test image in integration-tests workflow for PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsondav @jmank88 @msuchacz-cll