CCIP-4593 Create rmnproxy setRMN changeset #15674
Merged
+223
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
connorwstein
approved these changes
Dec 13, 2024
asoliman92
approved these changes
Dec 13, 2024
dimkouv
approved these changes
Dec 13, 2024
makramkd
approved these changes
Dec 13, 2024
| return nil | ||
| } | ||
|
|
||
| func SetRMNRemoteOnRMNProxy(e deployment.Environment, cfg SetRMNRemoteOnRMNProxyConfig) (deployment.ChangesetOutput, error) { |
There was a problem hiding this comment.
Naming nit (not a big fan of it though) SetRMNRemoteOnRMNProxyChangeset (getting really Java-ey 😢 )
Comment on lines
+56
to
+57
| multiSigs := make(map[uint64]*gethwrappers.ManyChainMultiSig) | ||
| timelocks := make(map[uint64]common.Address) |
There was a problem hiding this comment.
We do this so often I feel like we should just have a helper like state.GetAllMCMSes() and state.GetAllTimelocks() 😛
| @@ -30,6 +30,7 @@ import ( | |||
| ) | |||
|
|
|||
| func TestAddChainInbound(t *testing.T) { | |||
| t.Skipf("Skipping test as it is running into timeout issues, move the test into integration in-memory tests") | |||
There was a problem hiding this comment.
Can you create a ticket for this? Its weird that its timing out, it takes 90s on my laptop
There was a problem hiding this comment.
| @@ -286,6 +286,8 @@ func CreateKeys(t *testing.T, | |||
| } | |||
| backend := chain.Client.(*Backend).Sim | |||
| fundAddress(t, chain.DeployerKey, transmitters[evmChainID], assets.Ether(1000).ToInt(), backend) | |||
| // in sim chains the send transactions are performed with 0x0 address as the sender | |||
There was a problem hiding this comment.
Do you have a link to the docs where this is mentioned?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports