Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add changeset for set config on all 3 mcms contracts [DPA-1392] #15684

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

ecPablo
Copy link
Contributor

@ecPablo ecPablo commented Dec 13, 2024

DPA-1392

Support SetConfig calls either via an mcms proposal or directly executing the transactions. The changeset will call setConfig on the proposer, bypasser and canceller mcms contract that is set on the address book for each chain provided in the config.

@ecPablo ecPablo marked this pull request as ready for review December 13, 2024 15:56
@ecPablo ecPablo requested review from a team as code owners December 13, 2024 15:56
@ecPablo ecPablo requested a review from krehermann December 13, 2024 21:57
Copy link
Collaborator

@graham-chainlink graham-chainlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just few comments

deployment/common/changeset/set_config_mcms.go Outdated Show resolved Hide resolved
deployment/common/changeset/set_config_mcms.go Outdated Show resolved Hide resolved
deployment/common/changeset/set_config_mcms_test.go Outdated Show resolved Hide resolved
deployment/common/changeset/set_config_mcms_test.go Outdated Show resolved Hide resolved
deployment/common/changeset/set_config_mcms_test.go Outdated Show resolved Hide resolved
deployment/common/changeset/set_config_mcms_test.go Outdated Show resolved Hide resolved
deployment/common/changeset/set_config_mcms.go Outdated Show resolved Hide resolved
deployment/common/changeset/set_config_mcms.go Outdated Show resolved Hide resolved
deployment/common/changeset/set_config_mcms.go Outdated Show resolved Hide resolved
deployment/common/changeset/set_config_mcms.go Outdated Show resolved Hide resolved
@ecPablo ecPablo requested a review from connorwstein December 16, 2024 21:10
Copy link
Contributor

github-actions bot commented Dec 16, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants