Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added stream job delete capability #15690

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

msuchacz-cll
Copy link
Collaborator

@msuchacz-cll msuchacz-cll commented Dec 13, 2024

Stream job definition does not have it's own spec table. We need to extend the ORM to enable deleting such jobs.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@msuchacz-cll msuchacz-cll added the build-publish Build and Publish image to SDLC label Dec 13, 2024
@smartcontractkit smartcontractkit deleted a comment from Osazperry Dec 16, 2024
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Dec 16, 2024
@msuchacz-cll msuchacz-cll force-pushed the feat/add-stream-job-delete-capability branch from 27856e0 to 3db9372 Compare December 16, 2024 10:39
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 3db9372 (feat/add-stream-job-delete-capability).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestRunner_Error_Callback_AsyncJob 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 23.846666666s @smartcontractkit/foundations, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

samsondav
samsondav previously approved these changes Dec 16, 2024
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 3db9372 (feat/add-stream-job-delete-capability).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestRunner_Error_Callback_AsyncJob 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 23.846666666s @smartcontractkit/foundations, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@msuchacz-cll msuchacz-cll added build-test-image Will build the e2e test image in integration-tests workflow for PRs and removed build-test-image Will build the e2e test image in integration-tests workflow for PRs build-publish Build and Publish image to SDLC labels Dec 16, 2024
@samsondav samsondav added this pull request to the merge queue Dec 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 16, 2024
@Bwest981 Bwest981 added this pull request to the merge queue Dec 16, 2024
Merged via the queue into develop with commit ed6f486 Dec 16, 2024
174 checks passed
@Bwest981 Bwest981 deleted the feat/add-stream-job-delete-capability branch December 16, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants