Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP TXMv2 broadcast transactions #15709

Draft
wants to merge 3 commits into
base: txmv2_enablement
Choose a base branch
from
Draft

Conversation

eduard-cl
Copy link

No description provided.

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , lint , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakey Test Detection , SonarQube Scan

1. Error return value not checked: [Golang Lint]

Source of Error:
Golang Lint	2024-12-16T17:22:45.0383740Z ##[error]core/chains/evm/txm/txm.go:361:25: Error return value of `t.metrics.EmitTxMessage` is not checked (errcheck)
Golang Lint	2024-12-16T17:22:45.0384902Z 	t.metrics.EmitTxMessage(ctx, tx, address)
Golang Lint	2024-12-16T17:22:45.0385521Z 	 ^

Why: The error occurs because the return value of the function t.metrics.EmitTxMessage is not being checked. This is flagged by the errcheck linter, which ensures that all error return values are handled.

Suggested fix: Check the return value of t.metrics.EmitTxMessage and handle the error appropriately. For example:

if err := t.metrics.EmitTxMessage(ctx, tx, address); err != nil {
    // handle the error
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant