Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sol chains to serialized output #15711

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

add sol chains to serialized output #15711

wants to merge 1 commit into from

Conversation

tt-cll
Copy link

@tt-cll tt-cll commented Dec 16, 2024

  • Add Solana specific serialization to avoid polluting existing ChainView which is based on EVM primitives
  • Add TODOs based on where/how we need to add Solana specific support
  • We will need to consider how this scales to other non-EVMs in the future

Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and bd79507 (tt/solView).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestInitialAddChainAppliedTwice 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset false 3m42.076666666s @smartcontractkit/ccip, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakeguard Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/ccip/changeset, ubuntu-latest) , Flakey Test Detection , SonarQube Scan , Flakeguard Deployment Project / Report

1. Test failure: Run tests with flakeguard

Source of Error:
Run tests with flakeguard	2024-12-16T18:31:52.0866537Z | TestInitialAddChainAppliedTwice | 66.67% | false | false | false | 3 | 2 | 1 | 0 | github.com/smartcontractkit/chainlink/deployment/ccip/changeset | false | 3m42.076666666s | Unknown |
Run tests with flakeguard	2024-12-16T18:31:52.0890461Z ##[error]Process completed with exit code 1.

Why: The test TestInitialAddChainAppliedTwice failed once out of three runs, resulting in a pass ratio of 66.67%, which is below the required threshold of 100%. This caused the overall test run to be marked as failed.

Suggested fix: Investigate the specific test TestInitialAddChainAppliedTwice to identify why it is failing intermittently. Address any flakiness or instability in the test to ensure it passes consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant