Removed the jitter timeout from Mercury Transmitter #15717
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
msuchacz-cll
force-pushed
the
feat/test-revert-of-wsrpc-bump
branch
from
6a39a5e to
bd0296a
Compare
msuchacz-cll
changed the title
brunotm
force-pushed
the
feat/test-revert-of-wsrpc-bump
branch
from
5e9a1f8 to
86954b0
Compare
denis-chernov-smartcontract
previously approved these changes
Dec 16, 2024
samsondav
approved these changes
Dec 16, 2024
samsondav
force-pushed
the
feat/test-revert-of-wsrpc-bump
branch
from
86954b0 to
41426de
Compare
samsondav
previously approved these changes
Dec 16, 2024
jmank88
reviewed
Dec 16, 2024
Comment on lines
237
to
241
| res, err := func(ctx context.Context) (*pb.TransmitResponse, error) { | ||
| ctx, cancel := context.WithTimeout(ctx, utils.WithJitter(s.transmitTimeout)) | ||
| cancel() | ||
| return s.c.Transmit(ctx, t.Req) | ||
| }(ctx) |
There was a problem hiding this comment.
The closure only existed to support this context, so it can be removed:
res, err := s.c.Transmit(ctx, t.Req)
That sounds like a bug in the transmitter, not with the callers. If this method is going to accept a context, then it must handle timeouts correctly, and if we have unusual expectations then they should be documented. Do we have a ticket to track the root cause? |
brunotm
dismissed stale reviews from samsondav and denis-chernov-smartcontract
via
d202d06
brunotm
force-pushed
the
feat/test-revert-of-wsrpc-bump
branch
from
41426de to
d202d06
Compare
brunotm
force-pushed
the
feat/test-revert-of-wsrpc-bump
branch
from
d202d06 to
af4d1da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the issue with the jitter timeout on the Mercury Transmitter. It was causing the transmitter queue to get stuck and grow until we hit the limit.