Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter data feed table #1403

Merged
merged 24 commits into from
Sep 7, 2023
Merged

Filter data feed table #1403

merged 24 commits into from
Sep 7, 2023

Conversation

simkasss
Copy link
Contributor

Relates issues

relates #1384

Description

The Ethereum Mainnet price feed table has been enhanced with filtering by feed category, allowing users to select one category or multiple categories.

Changes

Added pagination and filtering by data feed category.

@vercel
Copy link

vercel bot commented Jul 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 5:48pm

@simkasss
Copy link
Contributor Author

@dwightjl, could you share your opinion on this change?
Additionally, I could add a search option (either by adding a search field above the table or modifying the search component in the Header) to enable searching for specific price feeds in the table.

@simkasss simkasss marked this pull request as ready for review July 25, 2023 08:24
@dwightjl
Copy link
Contributor

@dwightjl, could you share your opinion on this change? Additionally, I could add a search option (either by adding a search field above the table or modifying the search component in the Header) to enable searching for specific price feeds in the table.

This change is great and the search works well. Would it be easy to simply list ALL data feeds in one table and add a filter by network? Similar to what you have for the categories, but for each network instead. Ideally we have all data feeds listed in a single table (if performance allows), and let users filter and search to find what they need. Our network selector is just a temporary solution for helping people get the info they need.

We can probably merge this as it is, but if it's not hard to list everything together that would be even better.

dwightjl and others added 5 commits July 27, 2023 17:34
@dwightjl @simkasss
Token terminology update (smartcontractkit#1414)
38887aa
@yacine-benichou @dwightjl @simkasss
Vrf v2 cost calculator (smartcontractkit#1353)
ff4eb0e 
* Create design of VRF v2 cost calculator

* Add checkbox to have user choose method and compute parameters to compute vrf request cost

* Finalize VRF Cost Calculator

* Fix API url link

* fix API URL issue when calling

* Fix total cost output bugs + Add chain icons next to chain name in dropdown + Solve dropdown issue that didn't show on click when input is filled

* Fix bug when previous data are not refreshed after changing chain and network in calculator

* Fix responsive design issues + Add icons next to network options in dropdown menu + Fix issue where data wre not fetched from API when changing vrf method

* Cost calculator edits

* Refactor rebase issues + Fix issues that make API calls for BNB fail

* Fix issue where gas price input was not taken into account in request cost computation + Add maxCost computation in subscription method depending on gas lane chosen

* Apply design suggestions + Fix gas price that formatted the value before the user finished typing

* Syntax fix

* Add verification gas row in cost table of subscription method + Apply small syntax suggestions

* Edits

* Add Caret svg to dropdown input

* Writer edits

* Lint fix

---------

Co-authored-by: Yacine Benichou <[email protected]>
Co-authored-by: Dwight Lyle <[email protected]>
@yacine-benichou @simkasss
Fix issue where supported network link did not work for certain netwo… (
3769067 
smartcontractkit#1415)

* Fix issue where supported network link did not work for certain networks + Fix typos

* Edits

* Apply small syntax suggestion

---------

Co-authored-by: Yacine Benichou <[email protected]>
@aelmanaa @simkasss
fix tsconfig.json errors in vscode (smartcontractkit#1416)
9eaae20 
* fix tsconfig.json errors in vscode

* fix compile errors in solana pricefeeds off-chain-read.ts
@yacine-benichou @dwightjl @simkasss
Vrf v2 cost calculator (smartcontractkit#1418)
8e2837d 
* Create design of VRF v2 cost calculator

* Finalize VRF Cost Calculator

* Fix total cost output bugs + Add chain icons next to chain name in dropdown + Solve dropdown issue that didn't show on click when input is filled

* Fix responsive design issues + Add icons next to network options in dropdown menu + Fix issue where data wre not fetched from API when changing vrf method

* Cost calculator edits

* Refactor rebase issues + Fix issues that make API calls for BNB fail

* Fix Arbitrum computation issue by adding LINK Premium and price feed + Add L1 Gas Price input field to table when network is Arbitrum

* Fix API url + edits

* Fix issue when L1 gas price estimate could be undefined when switching networks

* Writer edits

---------

Co-authored-by: Yacine Benichou <[email protected]>
Co-authored-by: Dwight Lyle <[email protected]>
@simkasss
Copy link
Contributor Author

@dwightjl , okay, I will do it.

@simkasss simkasss mentioned this pull request Aug 7, 2023
Merged
@simkasss simkasss force-pushed the filter-data-feed-table branch from 1e8b2de to 1d2d44a Compare August 15, 2023 13:23
@simkasss
Copy link
Contributor Author

@dwightjl , can we divide this task into a few pull requests?

  • Implement filtering by data feed category and searching by pair.
  • Integrate filtering by network and combine all networks into one table.
  • Implement filtering by data feed type and combine all data feed types into one table.
  • Grey out the feed type/network selectors to indicate if a type is not available on a specific network.

I have just extracted the dropdown menu from the VRF v2 cost calculator to make it reusable in other features. For the next pull request, I will add this dropdown and combine all networks into one table.

@dwightjl maybe I should make some modifications so that you can approve this PR?
Currently, the Mainnet table has been improved by implementing filtering based on data feed category, pagination, and searching by main feed properties:

  • Pair name
  • Address
  • Asset name
  • Asset type
  • Reserve type (POR)
  • Data source (POR)
  • Attestation (POR)

The URL is in sync, everything appears to be working correctly to me. Please let me know if I have overlooked anything.

@simkasss simkasss marked this pull request as ready for review August 15, 2023 13:43
@dwightjl
Copy link
Contributor

This looks great I just need to set aside some time to go through it in greater detail. Sorry for the delay. I was out for a couple of days last week as well.

@dwightjl
Copy link
Contributor

dwightjl commented Sep 6, 2023

We're getting build errors on this now: https://github.com/smartcontractkit/documentation/actions/runs/6099817310/job/16552816596?pr=1403

It might be due to some changes in #1446

@simkasss
Copy link
Contributor Author

simkasss commented Sep 6, 2023

We're getting build errors on this now: https://github.com/smartcontractkit/documentation/actions/runs/6099817310/job/16552816596?pr=1403

It might be due to some changes in #1446

I am going to fix it now

@simkasss
Copy link
Contributor Author

simkasss commented Sep 6, 2023

@dwightjl it should be working correctly now, It would be perfect if you would check just in case, before merging.

@dwightjl dwightjl removed the blocked Waiting for another PR or a release. label Sep 7, 2023
@dwightjl dwightjl merged commit 6b1a2ec into smartcontractkit:main Sep 7, 2023
@dwightjl
Copy link
Contributor

dwightjl commented Sep 7, 2023

This is great work @simkasss. Thank you so much!

dorianbayart pushed a commit to dorianbayart/documentation that referenced this pull request Dec 25, 2023
@simkasss @dwightjl
@yacine-benichou @aelmanaa @dorianbayart
Filter data feed table (smartcontractkit#1403)
0c5e840 
* filter data-feed by category

* pagination wip

* filter eth mainnet table

* add search input

* url sync with search

* update placeholder

* Token terminology update (smartcontractkit#1414)

* Vrf v2 cost calculator (smartcontractkit#1353)

* Create design of VRF v2 cost calculator

* Add checkbox to have user choose method and compute parameters to compute vrf request cost

* Finalize VRF Cost Calculator

* Fix API url link

* fix API URL issue when calling

* Fix total cost output bugs + Add chain icons next to chain name in dropdown + Solve dropdown issue that didn't show on click when input is filled

* Fix bug when previous data are not refreshed after changing chain and network in calculator

* Fix responsive design issues + Add icons next to network options in dropdown menu + Fix issue where data wre not fetched from API when changing vrf method

* Cost calculator edits

* Refactor rebase issues + Fix issues that make API calls for BNB fail

* Fix issue where gas price input was not taken into account in request cost computation + Add maxCost computation in subscription method depending on gas lane chosen

* Apply design suggestions + Fix gas price that formatted the value before the user finished typing

* Syntax fix

* Add verification gas row in cost table of subscription method + Apply small syntax suggestions

* Edits

* Add Caret svg to dropdown input

* Writer edits

* Lint fix

---------

Co-authored-by: Yacine Benichou <[email protected]>
Co-authored-by: Dwight Lyle <[email protected]>

* Fix issue where supported network link did not work for certain netwo… (smartcontractkit#1415)

* Fix issue where supported network link did not work for certain networks + Fix typos

* Edits

* Apply small syntax suggestion

---------

Co-authored-by: Yacine Benichou <[email protected]>

* fix tsconfig.json errors in vscode (smartcontractkit#1416)

* fix tsconfig.json errors in vscode

* fix compile errors in solana pricefeeds off-chain-read.ts

* Vrf v2 cost calculator (smartcontractkit#1418)

* Create design of VRF v2 cost calculator

* Finalize VRF Cost Calculator

* Fix total cost output bugs + Add chain icons next to chain name in dropdown + Solve dropdown issue that didn't show on click when input is filled

* Fix responsive design issues + Add icons next to network options in dropdown menu + Fix issue where data wre not fetched from API when changing vrf method

* Cost calculator edits

* Refactor rebase issues + Fix issues that make API calls for BNB fail

* Fix Arbitrum computation issue by adding LINK Premium and price feed + Add L1 Gas Price input field to table when network is Arbitrum

* Fix API url + edits

* Fix issue when L1 gas price estimate could be undefined when switching networks

* Writer edits

---------

Co-authored-by: Yacine Benichou <[email protected]>
Co-authored-by: Dwight Lyle <[email protected]>

* add query parameters

* close dropdown on click outside

* flexible search box

* reset search and categories on network select

* typecheck

* fix queryString usage

---------

Co-authored-by: Dwight Lyle <[email protected]>
Co-authored-by: yacine-benichou <[email protected]>
Co-authored-by: Yacine Benichou <[email protected]>
Co-authored-by: Amine E <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwightjl dwightjl dwightjl approved these changes

@ritika-b ritika-b Awaiting requested review from ritika-b

@aelmanaa aelmanaa Awaiting requested review from aelmanaa aelmanaa is a code owner

@thedriftofwords thedriftofwords Awaiting requested review from thedriftofwords thedriftofwords is a code owner

@yacine-benichou yacine-benichou Awaiting requested review from yacine-benichou

Assignees
No one assigned
Labels
enhancement Enhance existing content or processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simkasss @dwightjl @yacine-benichou @aelmanaa