Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove p2p v1 field p2pBootstrapPeers #61

Merged
merged 1 commit into from
Dec 2, 2023
Merged

remove p2p v1 field p2pBootstrapPeers #61

merged 1 commit into from
Dec 2, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Dec 2, 2023

Remove the P2P V1 field p2pBootstrapPeers.

Supports:

@jmank88 jmank88 mentioned this pull request Dec 2, 2023
Merged
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f868c3) 88.31% compared to head (11e96a8) 88.31%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files         243      243           
  Lines        4441     4441           
  Branches      756      709   -47     
=======================================
  Hits         3922     3922           
- Misses        498      517   +19     
+ Partials       21        2   -19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jmank88 jmank88 marked this pull request as ready for review December 2, 2023 12:32
@jmank88 jmank88 requested review from a team and jkongie December 2, 2023 12:33
@jmank88 jmank88 merged commit 0953c48 into main Dec 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@jkongie jkongie Awaiting requested review from jkongie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmank88 @codecov-commenter @patrickhuie19