Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDP: fix autosetting of resend protocol #672

Closed
wants to merge 2 commits into from
+2 −1
Closed

SDP: fix autosetting of resend protocol #672

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58db488
smartdevice plugin: set protocol to resend if parameter is given fixed
onkelandy Aug 17, 2024
ff0e694
SDP: fix resend protocl setting
onkelandy Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/model/smartdeviceplugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,7 +1125,8 @@ class will never be used.

# Set protocol to resend only if protocol is not (yet) defined
if not protocol:
self._parameters[PLUGIN_ATTR_PROTOCOL] = 'resend'
self._parameters[PLUGIN_ATTR_PROTOCOL] = PROTO_RESEND
params[PLUGIN_ATTR_PROTOCOL] = PROTO_RESEND
# if send_retries is set and protocl is not set to resend, log info that protocol is overruling the parameter
elif protocol not in (PROTO_JSONRPC, PROTO_RESEND):
self.logger.debug(f'{PLUGIN_ATTR_SEND_RETRIES} is set to {resend}, but protocol {protocol} is requested, so resend may not apply')
Expand Down
Loading