Skip to content

Commit

Permalink
Corrected invalid classnames in Runtime code for foreach (#1001)
Browse files Browse the repository at this point in the history
Fixes #1000
  • Loading branch information
wisskid authored Apr 19, 2024
1 parent 5ee4363 commit 9a8702d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 10 deletions.
1 change: 1 addition & 0 deletions changelog/1000.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix invalid classnames in Runtime code for foreach [#1000](https://github.com/smarty-php/smarty/issues/1000)
18 changes: 8 additions & 10 deletions src/Runtime/ForeachRuntime.php
Original file line number Diff line number Diff line change
Expand Up @@ -116,22 +116,20 @@ public function init(
*
* @return int the count for arrays and objects that implement countable, 1 for other objects that don't, and 0
* for empty elements
* @throws \Exception
*/
public function count($value) {
if ($value instanceof IteratorAggregate) {
public function count($value): int
{
if ($value instanceof \IteratorAggregate) {
// Note: getIterator() returns a Traversable, not an Iterator
// thus rewind() and valid() methods may not be present
return iterator_count($value->getIterator());
} elseif ($value instanceof Iterator) {
return $value instanceof Generator ? 1 : iterator_count($value);
} elseif ($value instanceof Countable) {
} elseif ($value instanceof \Iterator) {
return $value instanceof \Generator ? 1 : iterator_count($value);
} elseif ($value instanceof \Countable) {
return count($value);
} elseif ($value instanceof PDOStatement) {
return $value->rowCount();
} elseif ($value instanceof Traversable) {
return iterator_count($value);
}
return count((array)$value);
return count((array) $value);
}

/**
Expand Down

0 comments on commit 9a8702d

Please sign in to comment.