Support unnamed function arguments to compiler plugins in Smarty 5 #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkreitz
commented
Nov 29, 2024
| @@ -91,8 +102,8 @@ protected function getAttributes($compiler, $attributes) { | |||
| if (isset($options[trim($mixed, '\'"')])) { | |||
| $_indexed_attr[trim($mixed, '\'"')] = true; | |||
| // shorthand attribute ? | |||
| } elseif (isset($this->shorttag_order[$key])) { | |||
| $_indexed_attr[$this->shorttag_order[$key]] = $mixed; | |||
| } elseif (!is_null($this->getShorthandOrder($key))) { | |||
There was a problem hiding this comment.
I think the type of $key is always int here, based on the fact that it looks like $attributes is a list<mixed> from the usage, but I do not know enough about the code base to know. If my assumption is incorrect, the type of the argument to getShorthandOrder needs to be changed to avoid crashing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the regression in Smarty 5 where a compiler function using unnamed arguments threw a "Too many shorthand
attributes" error, and adds unit test coverage.
Fixes #1085