-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Enable saving of multiple settings for tasks #2319
base: master
Are you sure you want to change the base?
Conversation
…d get task from gui
… into FWSaveSettings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. One thing to keep in mind is to make sure that the TaskSettingsViewModel initialization is in the same location as where the UpdateFieldsFromTask(TheTask) was previously called.
Width="200" VerticalAlignment="Center" HorizontalAlignment="Left" | ||
Click="Save_Click"/> | ||
<!--Command="{Binding SaveSettingsFromWindowCommand}" | ||
CommandParameter="{Binding TypedSettingsName}"--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Comments
…at are accidentally modified in previous codings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much closer. A few minor changes
…_Click methodn in the cs files of TaskWindows.
This PR is causing appveyor to hang for some reason. It stops in the middle of running the tests |
On clicking the save button, all task windows would parse the task window to construct the specific MetaMorpheusTask object. This has been broken out into two methods. GetTaskFromGui returns the task, and save task calls GetTaskFromGui. This enables to new task parameter saving architecture to parse the task from the gui without closing the window.