Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require More Evidence to Write mod to Pruned Database #2444

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nbollis
Copy link
Member

@nbollis nbollis commented Nov 27, 2024

PR Summary

This pull request introduces new features for handling pruned databases and generalizes terminology to support a broader range of biopolymers.

  • DictionaryExtensions.cs: Introduced DictionaryExtensions class with AddOrCreate method.
  • PrunedDatabaseWriter.cs: Added static class for writing modification-annotated databases asynchronously and handle the switch between RNA and Protein.
  • PostSearchAnalysisTask.cs: Generalized terminology from "peptide" to "bioPolymer" and methods for pruned database construction.
  • Program.cs and MainWindow.xaml.cs: Added event handler for PrunedDatabaseWriter.FinishedWritingFileHandler.
  • SearchTaskWindow.xaml and SearchTaskWindow.xaml.cs: Added UI elements and bindings for pruned database settings.

This is an experimental branch. The database writing by more evidence does not necessarily need to go into MetaMorpheus. This PR was posted to allow Claire to get an artifact. Incorporation into the main branch can wait until the utility of such a method has been validated.

@nbollis nbollis added Output Enhancement WIP Work in progress, not ready for review labels Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 88.97059% with 30 lines in your changes missing coverage. Please review.

Project coverage is 93.85%. Comparing base (fee5a0c) to head (fc6a5e5).

Files with missing lines Patch % Lines
...eus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs 86.42% 21 Missing and 9 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2444      +/-   ##
==========================================
+ Coverage   93.81%   93.85%   +0.03%     
==========================================
  Files         141      143       +2     
  Lines       22002    22079      +77     
  Branches     3015     3029      +14     
==========================================
+ Hits        20642    20723      +81     
+ Misses        910      906       -4     
  Partials      450      450              
Files with missing lines Coverage Δ
...aMorpheus/EngineLayer/Util/DictionaryExtensions.cs 100.00% <100.00%> (ø)
...heus/TaskLayer/SearchTask/PrundedDatabaseWriter.cs 100.00% <100.00%> (ø)
...aMorpheus/TaskLayer/SearchTask/SearchParameters.cs 100.00% <100.00%> (ø)
...eus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs 94.34% <86.42%> (+0.37%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Output Enhancement WIP Work in progress, not ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant