silencing compiler warnings #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andrewdavidsmith
commented
Oct 19, 2023
andrewdavidsmith
commented
- EpireadStats: removing constexpr as it's not always supported yet for the way it was used
- bsrate: adding to_string around an integer that was concatenated to a string
- MSite.cpp: putting a guard around use of from_chars because on osx it is not yet available from c++17
- amrfinder.cpp: ensuring move is std::move because it must be explicit fir some compilers. Also casting properly for size_t seeming to be unsigned long long on apple
- Removing unused variables to silence warnings. In some cases these seem to have been important
- amrfinder: Fixing a warning issues by using decltype in a static cast
- ThreeStateHMM: putting guards around backward score as it's only used to compare with forward score in debug situation within assert
- Fixes format: max distance when merging mates seems ignored #169.
- pmd: many places the vector indicating array_status had been passed around despite only being used in a few of those places. These were deleted
… the way it was used
… is not yet available from c++17
… fir some compilers. Also casting properly for size_t seeming to be unsigned long long on apple
…em to have been important
… to compare with forward score in debug situation within assert
…round despite only being used in a few of those places. These were deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.