Tournaments: Support team locking #9283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You could probably just validate once on their first battle, then cache it and assume it's fine the rest of the time. |
|
Unless it becomes a serious issue I really don't want to rewrite battleready for this, there's not an easy fix because it validates legality and applies filters at the same time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs support from client, will write that later.
This adds a new command
/tour teamlockthat allows a tournament to force players to use the same team throughout the tournament. It can only be set before the tournament starts.Potential issue: This can break if a ruleset is hotpatched during the tournament that makes a player's team invalid. Maybe I should add a way for prepBattle to bypass validation?