-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CGT: Improve Sleep Talk and boosting sets #9998
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyuk-bot
force-pushed
the
cgtsleeptalk
branch
from
December 20, 2023 05:58
b7938ef
to
75eccd7
Compare
KrisXV
reviewed
Jan 3, 2024
KrisXV
reviewed
Jan 3, 2024
pyuk-bot
commented
Nov 19, 2024
protected static moveIsSpecial(move: Move, species: Species) { | ||
if (move.category === 'Special') { | ||
return !(move.damageCallback || move.damage); | ||
} else if (['terablast', 'terastarstorm', 'photongeyser', 'shellsidearm'].includes(move.id)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, this should have been the first check in this function since all those moves pass the other one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
moveStats
object to keep track of information about the moveset so far which should help speed up the move weighing process a little. It also: