Better default for numbers

smonn · Jun 27, 2022 · c27d5de · c27d5de
1 parent 962c4c3
commit c27d5de
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/numbers.ts b/src/numbers.ts
@@ -45,7 +45,9 @@ export function applyNumberConfig(
   let parsedValue = config.parser(value);
   if (
     config.default !== undefined &&
-    (parsedValue === undefined || parsedValue === null)
+    (parsedValue === undefined ||
+      parsedValue === null ||
+      Number.isNaN(parsedValue))
   ) {
     parsedValue = config.default;
   }

diff --git a/test/numbers.test.ts b/test/numbers.test.ts
@@ -277,6 +277,24 @@ test('number default', async () => {
     isValid: true,
     field: undefined,
   });
+  assert.equal(await validate(null), {
+    state: 'valid',
+    value: 5,
+    isValid: true,
+    field: undefined,
+  });
+  assert.equal(await validate(Number.NaN), {
+    state: 'valid',
+    value: 5,
+    isValid: true,
+    field: undefined,
+  });
+  assert.equal(await validate(123), {
+    state: 'valid',
+    value: 123,
+    isValid: true,
+    field: undefined,
+  });
 });
 
 test.run();