Users can now spectate via basic web ui #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web UI is powered by quarkus own `qute`, html, js and websocket Because we don't want to make things to easy, our web ui only allows spectator mode. Users will need to use the TUI client (or hack their own) to play. Both web ui and TUI will only display playing users and hide spectators.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
============================================
- Coverage 89.55% 89.46% -0.10%
- Complexity 110 113 +3
============================================
Files 23 24 +1
Lines 1427 1443 +16
Branches 27 30 +3
============================================
+ Hits 1278 1291 +13
- Misses 138 140 +2
- Partials 11 12 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web UI is powered by quarkus own
qute, html, js and websocketBecause we don't want to make things to easy, our web ui only allows spectator mode. Users will need to use the TUI client (or hack their own) to play.
Both web ui and TUI will only display playing users and hide spectators.