Skip to content

Commit

Permalink
#241 actions release maven and release gradle act the same way as rel…
Browse files Browse the repository at this point in the history
…ease (#243)

* Update actions

* Undo accidental changes

* Fixes
  • Loading branch information
janDuinRod authored May 12, 2023
1 parent bb878b0 commit 306b340
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/gradle-portal-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
check-version:
runs-on: ubuntu-latest
needs: [check-pr-labels]
if: ${{ contains(needs.check-pr-labels.outputs.labels, 'release') || contains(needs.check-pr-labels.outputs.labels, 'release-gradle') }}
if: ${{ contains(needs.check-pr-labels.outputs.labels, 'release') || contains(needs.check-pr-labels.outputs.labels, 'gradle') }}
steps:
- uses: actions/checkout@v3
- name: Check if engine version is updated
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gradle-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ concurrency: pr-gradle-${{ github.event.pull_request.id }}
jobs:
check-version:
runs-on: ubuntu-latest
if: ${{ contains(github.event.pull_request.labels.*.name, 'release') || contains(github.event.pull_request.labels.*.name, 'release-gradle') }}
if: ${{ contains(github.event.pull_request.labels.*.name, 'release') || contains(github.event.pull_request.labels.*.name, 'gradle') }}
steps:
- uses: actions/checkout@v3
- name: Gradle version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/maven-central-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
check-version:
runs-on: ubuntu-latest
needs: [check-pr-labels]
if: ${{ contains(needs.check-pr-labels.outputs.labels, 'release') || contains(needs.check-pr-labels.outputs.labels, 'release-maven') }}
if: ${{ contains(needs.check-pr-labels.outputs.labels, 'release') || contains(needs.check-pr-labels.outputs.labels, 'maven') }}
steps:
- uses: actions/checkout@v3
- name: Check if version is updated
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/maven-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ concurrency: pr-${{ github.event.pull_request.id }}
jobs:
check-version:
runs-on: ubuntu-latest
if: ${{ contains(github.event.pull_request.labels.*.name, 'release') || contains(github.event.pull_request.labels.*.name, 'release-maven') }}
if: ${{ contains(github.event.pull_request.labels.*.name, 'release') || contains(github.event.pull_request.labels.*.name, 'maven') }}
steps:
- uses: actions/checkout@v3
- name: Check if version is updated
Expand Down Expand Up @@ -75,9 +75,9 @@ jobs:
if: github.event.pull_request.mergeable == true
steps:
- name: Warn about missing labels
if: ${{ !contains(github.event.pull_request.labels.*.name, 'release') && !contains(github.event.pull_request.labels.*.name, 'documentation') && !contains(github.event.pull_request.labels.*.name, 'release-maven') && !contains(github.event.pull_request.labels.*.name, 'release-gradle')}}}
if: ${{ !contains(github.event.pull_request.labels.*.name, 'release') && !contains(github.event.pull_request.labels.*.name, 'documentation') && !contains(github.event.pull_request.labels.*.name, 'maven') && !contains(github.event.pull_request.labels.*.name, 'gradle')}}}
uses: thollander/actions-comment-pull-request@v2
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
message: "This pull request hasn't been labeled as `release`, `release-gradle`, `release-maven` nor `documentation`. Please ensure this is intentional before merging."
message: "This pull request hasn't been labeled as `release`, `gradle`, `maven` nor `documentation`. Please ensure this is intentional before merging."
comment_tag: label-warn
5 changes: 2 additions & 3 deletions .github/workflows/pr-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@ jobs:
if: github.event.review.state == 'approved'
steps:
- name: Warn about missing labels
if: ${{ !contains(github.event.pull_request.labels.*.name, 'release') && !contains(github.event.pull_request.labels.*.name, 'documentation') && !contains(github.event.pull_request.labels.*.name, 'release-maven') && !contains(github.event.pull_request.labels.*.name, 'release-gradle')}}}
if: ${{ !contains(github.event.pull_request.labels.*.name, 'release') && !contains(github.event.pull_request.labels.*.name, 'documentation') && !contains(github.event.pull_request.labels.*.name, 'maven') && !contains(github.event.pull_request.labels.*.name, 'gradle')}}}
uses: thollander/actions-comment-pull-request@v2
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
message: "This pull request hasn't been labeled as `release`, `release-gradle`, `release-maven` nor `documentation`. Please ensure this is intentional before merging."
message: "This pull request hasn't been labeled as `release`, `gradle`, `maven` nor `documentation`. Please ensure this is intentional before merging."
comment_tag: label-warn
:w
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ project. We encourage you to follow them and help us create a better product!
follow is [SemVer](http://semver.org/).
4. If your Pull Request corresponds to a new release, label it as `release` to
create a new version of both the maven and gradle plugins. To create a new
release for either of them individually you can use the tags `release-maven`
or `release-gradle`. If it updates the documentation, label it as `documentation`.
release for either of them individually you can use the tags `maven`
or `gradle`. If it updates the documentation, label it as `documentation`.
You can add both a release and a documentation label if needed.
5. You may squash and merge the pull request once you have the sign-off of two
other developers. If you do not have permission to merge, you may request the
Expand Down

0 comments on commit 306b340

Please sign in to comment.