Test pr 1211

.github/workflows/build-test.yml

@@ -2,7 +2,7 @@ name: Build and Test
 
 on:
     push:
-        braches:
+        branches:
             - master
         tags:
             - v*
@@ -30,11 +30,11 @@ jobs:
           fail-fast: false
         name: Check linter
         steps:
-          - uses: actions/checkout@v1
+          - uses: actions/checkout@v4
           - name: Setup go
             uses: actions/setup-go@v5
             with:
-              go-version: '1.21'
+              go-version-file: "./go.mod"
           - name: golangci-lint
             uses: golangci/golangci-lint-action@v6
             with:
@@ -51,7 +51,7 @@ jobs:
                 go: [ '1.21', '1.22', '1.23' ]
         name: ${{ matrix.cloud }} Go ${{ matrix.go }} on Ubuntu
         steps:
-            - uses: actions/checkout@v1
+            - uses: actions/checkout@v4
             - name: Setup go
               uses: actions/setup-go@v5
               with:
@@ -77,7 +77,7 @@ jobs:
                 go: [ '1.21', '1.22', '1.23' ]
         name: ${{ matrix.cloud }} Go ${{ matrix.go }} on Mac
         steps:
-            - uses: actions/checkout@v1
+            - uses: actions/checkout@v4
             - name: Setup go
               uses: actions/setup-go@v5
               with:
@@ -102,7 +102,7 @@ jobs:
                 go: [ '1.21', '1.22', '1.23' ]
         name: ${{ matrix.cloud }} Go ${{ matrix.go }} on Windows
         steps:
-            - uses: actions/checkout@v1
+            - uses: actions/checkout@v4
             - name: Setup go
               uses: actions/setup-go@v5
               with:

.gitignore

@@ -1,4 +1,5 @@
 .idea/
+.vscode/
 parameters*.json
 parameters*.bat
 *.p8
@@ -11,6 +12,8 @@ wss-golang-agent.config
 wss-unified-agent.jar
 whitesource/
 *.swp
+cp.out
+__debug_bin*
 
 # exclude vendor
 vendor

bind_uploader.go

@@ -118,7 +118,7 @@ func (bu *bindUploader) createStageIfNeeded() error {
 		return (&SnowflakeError{
 			Number:   code,
 			SQLState: data.Data.SQLState,
-			Message:  err.Error(),
+			Message:  data.Message,
 			QueryID:  data.Data.QueryID,
 		}).exceptionTelemetry(bu.sc)
 	}

bindings_test.go

@@ -8,9 +8,11 @@
 	"database/sql"
 	"fmt"
 	"log"
+	"math"
 	"math/big"
 	"math/rand"
 	"reflect"
+	"slices"
 	"strconv"
 	"strings"
 	"testing"
@@ -70,7 +72,7 @@
 				dbt.mustExec("INSERT INTO test VALUES (1, ?)", expected)
 				rows = dbt.mustQuery("SELECT value FROM test WHERE id = ?", 1)
 				defer func() {
-				    assertNilF(t, rows.Close())
+					assertNilF(t, rows.Close())
 				}()
 				if rows.Next() {
 					assertNilF(t, rows.Scan(&out))
@@ -203,14 +205,14 @@
 			dbt.Fatal(err.Error())
 		}
 		defer func() {
-		    assertNilF(t, stmt.Close())
+			assertNilF(t, stmt.Close())
 		}()
 		if _, err = stmt.Exec(DataTypeTimestampTz, expected); err != nil {
 			dbt.Fatal(err)
 		}
 		rows := dbt.mustQuery("SELECT tz FROM tztest WHERE id=?", 1)
 		defer func() {
-		    assertNilF(t, rows.Close())
+			assertNilF(t, rows.Close())
 		}()
 		var v time.Time
 		if rows.Next() {
@@ -258,7 +260,7 @@
 
 			rows := dbt.mustQuery("SELECT tz FROM timeStructTest WHERE id=?", &expectedID)
 			defer func() {
-			    assertNilF(t, rows.Close())
+				assertNilF(t, rows.Close())
 			}()
 			var v time.Time
 			if rows.Next() {
@@ -307,7 +309,7 @@
 
 			rows := dbt.mustQuery("SELECT tz FROM timeStructTest WHERE id=?", &expectedID)
 			defer func() {
-			    assertNilF(t, rows.Close())
+				assertNilF(t, rows.Close())
 			}()
 			var v time.Time
 			if rows.Next() {
@@ -329,7 +331,7 @@
 		rows := dbt.mustQueryContext(
 			WithHigherPrecision(context.Background()), selectVariousTypes)
 		defer func() {
-		    assertNilF(t, rows.Close())
+			assertNilF(t, rows.Close())
 		}()
 		if !rows.Next() {
 			dbt.Error("failed to query")
@@ -357,7 +359,7 @@
 	runDBTest(t, func(dbt *DBTest) {
 		rows := dbt.mustQuery(selectVariousTypes)
 		defer func() {
-		    assertNilF(t, rows.Close())
+			assertNilF(t, rows.Close())
 		}()
 		if !rows.Next() {
 			dbt.Error("failed to query")
@@ -382,6 +384,71 @@
 	})
 }
 
+func TestBulkArrayBindingUUID(t *testing.T) {
+	max := math.Pow10(5) // 100K because my power is maximum
+	expectedUuids := make([]any, int(max))
+
+	createTable := "CREATE OR REPLACE TABLE TEST_PREP_STATEMENT (uuid VARCHAR)"
+	insert := "INSERT INTO TEST_PREP_STATEMENT (uuid) VALUES (?)"
+
+	for i := range expectedUuids {
+		expectedUuids[i] = newTestUUID()
+	}
+
+	slices.SortStableFunc(expectedUuids, func(i, j any) int {
+		return strings.Compare(i.(testUUID).String(), j.(testUUID).String())
+	})
+
+	runDBTest(t, func(dbt *DBTest) {
+		var rows *RowsExtended
+		t.Cleanup(func() {
+			if rows != nil {
+				assertNilF(t, rows.Close())
+			}
+
+			dbt.exec(deleteTableSQL)
+		})
+
+		dbt.mustExec(createTable)
+
+		res := dbt.mustExec(insert, Array(&expectedUuids))
+
+		affected, err := res.RowsAffected()
+		if err != nil {
+			t.Fatalf("failed to get affected rows. err: %s", err)
+		} else if affected != int64(max) {
+			t.Fatalf("failed to insert all rows. expected: %f.0, got: %v", max, affected)
+		}
+
+		rows = dbt.mustQuery("SELECT * FROM TEST_PREP_STATEMENT ORDER BY uuid")
+		if rows == nil {
+			t.Fatal("failed to query")
+		}
+
+		if rows.Err() != nil {
+			t.Fatalf("failed to query. err: %s", rows.Err())
+		}
+
+		var actual = make([]testUUID, len(expectedUuids))
+
+		for i := 0; rows.Next(); i++ {
+			var (
+				out testUUID
+			)
+			if err := rows.Scan(&out); err != nil {
+				t.Fatal(err)
+			}
+
+			actual[i] = out
+		}
+
+		for i := range expectedUuids {
+			assertEqualE(t, actual[i], expectedUuids[i])
+		}
+	})
+
+}
+
 func TestBulkArrayBindingInterfaceNil(t *testing.T) {
 	nilArray := make([]any, 1)
 
@@ -396,7 +463,7 @@
 			Array(&nilArray, TimeType))
 		rows := dbt.mustQuery(selectAllSQL)
 		defer func() {
-		    assertNilF(t, rows.Close())
+			assertNilF(t, rows.Close())
 		}()
 
 		var v0 sql.NullInt32
@@ -481,7 +548,7 @@
 			Array(&boolArray), Array(&strArray), Array(&byteArray), Array(&int64Array))
 		rows := dbt.mustQuery(selectAllSQLBulkArray)
 		defer func() {
-		    assertNilF(t, rows.Close())
+			assertNilF(t, rows.Close())
 		}()
 
 		var v0 sql.NullInt32
@@ -586,7 +653,7 @@
 
 		rows := dbt.mustQuery(selectAllSQLBulkArrayDateTimeTimestamp)
 		defer func() {
-		    assertNilF(t, rows.Close())
+			assertNilF(t, rows.Close())
 		}()
 
 		var v0, v1, v2, v3, v4 sql.NullTime
@@ -695,7 +762,7 @@
 			Array(&tmArray, TimeType))
 		rows := dbt.mustQuery(selectAllSQL)
 		defer func() {
-		    assertNilF(t, rows.Close())
+			assertNilF(t, rows.Close())
 		}()
 
 		var v0 int
@@ -777,7 +844,7 @@
 		dbt.mustExec(fmt.Sprintf("insert into %v values (?, ?, ?, ?, ?, ?, ?, ?)", dbname), Array(&intArr), Array(&strArr), Array(&ltzArr, TimestampLTZType), Array(&tzArr, TimestampTZType), Array(&ntzArr, TimestampNTZType), Array(&dateArr, DateType), Array(&timeArr, TimeType), Array(&binArr))
 		rows := dbt.mustQuery("select * from " + dbname + " order by c1")
 		defer func() {
-		    assertNilF(t, rows.Close())
+			assertNilF(t, rows.Close())
 		}()
 		cnt := 0
 		var i int
@@ -825,7 +892,7 @@
 		dbt.mustExec(fmt.Sprintf("insert into %v values (?, ?, ?, ?)", dbname), Array(&secondsArr, TimeType), Array(&millisecondsArr, TimeType), Array(&microsecondsArr, TimeType), Array(&nanosecondsArr, TimeType))
 		rows := dbt.mustQuery("select * from " + dbname)
 		defer func() {
-		    assertNilF(t, rows.Close())
+			assertNilF(t, rows.Close())
 		}()
 		cnt := 0
 		var s, ms, us, ns time.Time
@@ -866,7 +933,7 @@
 				Array(&randomStrings))
 			rows := dbt.mustQuery("select count(*) from " + tempTableName)
 			defer func() {
-			    assertNilF(t, rows.Close())
+				assertNilF(t, rows.Close())
 			}()
 			if rows.Next() {
 				var count int
@@ -878,7 +945,7 @@
 
 		rows := dbt.mustQuery("select count(*) from " + tempTableName)
 		defer func() {
-		    assertNilF(t, rows.Close())
+			assertNilF(t, rows.Close())
 		}()
 		if rows.Next() {
 			var count int
@@ -909,7 +976,7 @@
 
 		rows := dbt.mustQuery("select * from binding_test order by c1")
 		defer func() {
-		    assertNilF(t, rows.Close())
+			assertNilF(t, rows.Close())
 		}()
 		cnt := startNum
 		var i int
@@ -959,7 +1026,7 @@
 
 		rows := dbt.mustQuery("select * from binding_test order by c1,c2")
 		defer func() {
-		    assertNilF(t, rows.Close())
+			assertNilF(t, rows.Close())
 		}()
 		cnt := startNum
 		var i sql.NullInt32
@@ -1042,7 +1109,7 @@
 					t.Fatal(err)
 				}
 				defer func() {
-				    assertNilF(t, rows.Close())
+					assertNilF(t, rows.Close())
 				}()
 				if rows.Err() != nil {
 					t.Fatal(err)
@@ -1144,7 +1211,7 @@
 						t.Fatal(err)
 					}
 					defer func() {
-					    assertNilF(t, rows.Close())
+						assertNilF(t, rows.Close())
 					}()
 					if !rows.Next() {
 						t.Fatal("Expected to return a row")
@@ -1194,7 +1261,7 @@
 				rows, err := dbt.query(fmt.Sprintf("SELECT randstr(%v, 124)", testSize))
 				assertNilF(t, err)
 				defer func() {
-				    assertNilF(t, rows.Close())
+					assertNilF(t, rows.Close())
 				}()
 				assertTrueF(t, rows.Next(), fmt.Sprintf("no rows returned for the LOB size %v", testSize))
 
@@ -1227,7 +1294,7 @@
 			rows, err := dbt.query("select randstr(20000000, random())")
 			assertNilF(t, err)
 			defer func() {
-			    assertNilF(t, rows.Close())
+				assertNilF(t, rows.Close())
 			}()
 		})
 	})
@@ -1308,7 +1375,7 @@
 				rows, err := dbt.query("SELECT * FROM lob_test_table")
 				assertNilF(t, err)
 				defer func() {
-				    assertNilF(t, rows.Close())
+					assertNilF(t, rows.Close())
 				}()
 				assertTrueF(t, rows.Next(), fmt.Sprintf("%s: no rows returned", tc.testDesc))