Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snow 895534 add entries to cache #889

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Snow 895534 add entries to cache #889

merged 1 commit into from
Aug 28, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Aug 21, 2023 •
edited
Loading

Description

When HTAP query context entries are returned from the server, we save it in the local cache.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

semgrep-snowflake[bot]
semgrep-snowflake bot reviewed Aug 21, 2023
View reviewed changes
ocsp.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-895534-add-entries-to-cache branch 6 times, most recently from 17f5b45 to ea369eb Compare August 24, 2023 05:06
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review August 24, 2023 05:08
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner August 24, 2023 05:08
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Aug 24, 2023
View reviewed changes
htap.go Outdated Show resolved Hide resolved
htap_test.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-895534-add-entries-to-cache branch 2 times, most recently from 36db7f2 to 3982988 Compare August 24, 2023 13:07
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-igarish
Copy link
Collaborator

I will review it but please check why tests are failing.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-895534-add-entries-to-cache branch 3 times, most recently from 10f8fa6 to fbd692e Compare August 25, 2023 06:21
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-895534-add-entries-to-cache branch from fbd692e to c9847d3 Compare August 25, 2023 06:22
@sfc-gh-pfus sfc-gh-pfus merged commit 461b653 into master Aug 28, 2023
21 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-895534-add-entries-to-cache branch August 28, 2023 11:40
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz left review comments

@semgrep-snowflake semgrep-snowflake[bot] semgrep-snowflake[bot] left review comments

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-igarish sfc-gh-igarish Awaiting requested review from sfc-gh-igarish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-pfus @sfc-gh-igarish @sfc-gh-dprzybysz @sfc-gh-pmotacki