Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-726742: Implement GetQueryId for statements #899

Merged
merged 1 commit into from
Aug 29, 2023
Merged

SNOW-726742: Implement GetQueryId for statements #899

merged 1 commit into from
Aug 29, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Aug 28, 2023 •
edited
Loading

Description

Implement GetQueryId on statements

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-726742-query-id branch 2 times, most recently from af556a2 to 3680da5 Compare August 28, 2023 09:58
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review August 28, 2023 10:39
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner August 28, 2023 10:39
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-726742-query-id branch 3 times, most recently from 36a41dd to 264a32d Compare August 28, 2023 10:47
sfc-gh-igarish
sfc-gh-igarish approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus merged commit 6e38e3c into master Aug 29, 2023
21 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-726742-query-id branch August 29, 2023 07:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz left review comments

@sfc-gh-dheyman-1 sfc-gh-dheyman-1 sfc-gh-dheyman-1 approved these changes

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-pfus @sfc-gh-igarish @sfc-gh-dprzybysz @sfc-gh-dheyman-1