Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-895537: Send query context with request #904

Merged
merged 1 commit into from
Sep 12, 2023
Merged

SNOW-895537: Send query context with request #904

merged 1 commit into from
Sep 12, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Aug 30, 2023 •
edited
Loading

Description

Query contexts are now sent to snowflake backend.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-895537-send-qcc branch 10 times, most recently from 5d749d4 to 74affb8 Compare September 4, 2023 11:39
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review September 4, 2023 11:40
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner September 4, 2023 11:40
sfc-gh-dheyman-1
sfc-gh-dheyman-1 approved these changes Sep 5, 2023
View reviewed changes
connection.go Outdated Show resolved Hide resolved
connection.go Show resolved Hide resolved
connection.go Outdated Show resolved Hide resolved
sfc-gh-dstempniak
sfc-gh-dstempniak reviewed Sep 5, 2023
View reviewed changes
htap_test.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-895537-send-qcc branch 2 times, most recently from 30b5c41 to 640dfc1 Compare September 7, 2023 11:21
@sfc-gh-pfus sfc-gh-pfus merged commit 1043498 into master Sep 12, 2023
21 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-895537-send-qcc branch September 12, 2023 05:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dheyman-1 sfc-gh-dheyman-1 sfc-gh-dheyman-1 approved these changes

@sfc-gh-dstempniak sfc-gh-dstempniak sfc-gh-dstempniak approved these changes

@sfc-gh-igarish sfc-gh-igarish Awaiting requested review from sfc-gh-igarish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-pfus @sfc-gh-igarish @sfc-gh-dstempniak @sfc-gh-dheyman-1