Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-898296: Enable HTAP optimisations in tests #908

Merged
merged 1 commit into from
Sep 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions aaa_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package gosnowflake

import "testing"

func TestShowServerVersion(t *testing.T) {
runDBTest(t, func(dbt *DBTest) {
rows := dbt.mustQuery("SELECT CURRENT_VERSION()")
defer rows.Close()

var version string
rows.Next()
rows.Scan(&version)
println(version)
})
}
16 changes: 12 additions & 4 deletions connection.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,18 @@ func (sc *snowflakeConn) exec(
}

logger.WithContext(ctx).Info("Exec/Query SUCCESS")
sc.cfg.Database = data.Data.FinalDatabaseName
sc.cfg.Schema = data.Data.FinalSchemaName
sc.cfg.Role = data.Data.FinalRoleName
sc.cfg.Warehouse = data.Data.FinalWarehouseName
if data.Data.FinalDatabaseName != "" {
sc.cfg.Database = data.Data.FinalDatabaseName
}
if data.Data.FinalSchemaName != "" {
sc.cfg.Schema = data.Data.FinalSchemaName
}
if data.Data.FinalWarehouseName != "" {
sc.cfg.Warehouse = data.Data.FinalWarehouseName
}
if data.Data.FinalRoleName != "" {
sc.cfg.Role = data.Data.FinalRoleName
}
sc.populateSessionParameters(data.Data.Parameters)
return data, err
}
Expand Down
165 changes: 165 additions & 0 deletions htap_test.go
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
package gosnowflake

import (
"context"
"database/sql/driver"
"fmt"
"reflect"
"strconv"
"strings"
"testing"
"time"
)
Expand Down Expand Up @@ -409,3 +412,165 @@ func TestHybridTablesE2E(t *testing.T) {
})
})
}

func TestHTAPOptimizations(t *testing.T) {
if runningOnGithubAction() {
t.Skip("insufficient permissions")
}
for _, useHtapOptimizations := range []bool{true, false} {
runSnowflakeConnTest(t, func(sct *SCTest) {
t.Run("useHtapOptimizations="+strconv.FormatBool(useHtapOptimizations), func(t *testing.T) {
if useHtapOptimizations {
sct.mustExec("ALTER SESSION SET ENABLE_SNOW_654741_FOR_TESTING = true", nil)
sfc-gh-dheyman marked this conversation as resolved.
Show resolved Hide resolved
}
runID := time.Now().UnixMilli()
t.Run("Schema", func(t *testing.T) {
newSchema := fmt.Sprintf("test_schema_%v", runID)
if strings.EqualFold(sct.sc.cfg.Schema, newSchema) {
t.Errorf("schema should not be switched")
}

sct.mustExec(fmt.Sprintf("CREATE SCHEMA %v", newSchema), nil)
defer sct.mustExec(fmt.Sprintf("DROP SCHEMA %v", newSchema), nil)

if !strings.EqualFold(sct.sc.cfg.Schema, newSchema) {
t.Errorf("schema should be switched, expected %v, got %v", newSchema, sct.sc.cfg.Schema)
}

query := sct.mustQuery("SELECT 1", nil)
query.Close()

if !strings.EqualFold(sct.sc.cfg.Schema, newSchema) {
t.Errorf("schema should be switched, expected %v, got %v", newSchema, sct.sc.cfg.Schema)
}
})
t.Run("Database", func(t *testing.T) {
newDatabase := fmt.Sprintf("test_database_%v", runID)
if strings.EqualFold(sct.sc.cfg.Database, newDatabase) {
t.Errorf("database should not be switched")
}

sct.mustExec(fmt.Sprintf("CREATE DATABASE %v", newDatabase), nil)
defer sct.mustExec(fmt.Sprintf("DROP DATABASE %v", newDatabase), nil)

if !strings.EqualFold(sct.sc.cfg.Database, newDatabase) {
t.Errorf("database should be switched, expected %v, got %v", newDatabase, sct.sc.cfg.Database)
}

query := sct.mustQuery("SELECT 1", nil)
query.Close()

if !strings.EqualFold(sct.sc.cfg.Database, newDatabase) {
t.Errorf("database should be switched, expected %v, got %v", newDatabase, sct.sc.cfg.Database)
}
})
t.Run("Warehouse", func(t *testing.T) {
newWarehouse := fmt.Sprintf("test_warehouse_%v", runID)
if strings.EqualFold(sct.sc.cfg.Warehouse, newWarehouse) {
t.Errorf("warehouse should not be switched")
}

sct.mustExec(fmt.Sprintf("CREATE WAREHOUSE %v", newWarehouse), nil)
defer sct.mustExec(fmt.Sprintf("DROP WAREHOUSE %v", newWarehouse), nil)

if !strings.EqualFold(sct.sc.cfg.Warehouse, newWarehouse) {
t.Errorf("warehouse should be switched, expected %v, got %v", newWarehouse, sct.sc.cfg.Warehouse)
}

query := sct.mustQuery("SELECT 1", nil)
query.Close()

if !strings.EqualFold(sct.sc.cfg.Warehouse, newWarehouse) {
t.Errorf("warehouse should be switched, expected %v, got %v", newWarehouse, sct.sc.cfg.Warehouse)
}
})
t.Run("Role", func(t *testing.T) {
if strings.EqualFold(sct.sc.cfg.Role, "PUBLIC") {
t.Errorf("role should not be public for this test")
}

sct.mustExec("USE ROLE public", nil)

if !strings.EqualFold(sct.sc.cfg.Role, "PUBLIC") {
t.Errorf("role should be switched, expected public, got %v", sct.sc.cfg.Role)
}

query := sct.mustQuery("SELECT 1", nil)
query.Close()

if !strings.EqualFold(sct.sc.cfg.Role, "PUBLIC") {
t.Errorf("role should be switched, expected public, got %v", sct.sc.cfg.Role)
}
})
t.Run("Session param - DATE_OUTPUT_FORMAT", func(t *testing.T) {
if !strings.EqualFold(*sct.sc.cfg.Params["date_output_format"], "YYYY-MM-DD") {
t.Errorf("should use default date_output_format, but got: %v", *sct.sc.cfg.Params["date_output_format"])
}

sct.mustExec("ALTER SESSION SET DATE_OUTPUT_FORMAT = 'DD-MM-YYYY'", nil)
defer sct.mustExec("ALTER SESSION SET DATE_OUTPUT_FORMAT = 'YYYY-MM-DD'", nil)

if !strings.EqualFold(*sct.sc.cfg.Params["date_output_format"], "DD-MM-YYYY") {
t.Errorf("date output format should be switched, expected DD-MM-YYYY, got %v", sct.sc.cfg.Params["date_output_format"])
}

query := sct.mustQuery("SELECT 1", nil)
query.Close()

if !strings.EqualFold(*sct.sc.cfg.Params["date_output_format"], "DD-MM-YYYY") {
t.Errorf("date output format should be switched, expected DD-MM-YYYY, got %v", sct.sc.cfg.Params["date_output_format"])
}
})
})
})
}
}

func TestConnIsCleanAfterClose(t *testing.T) {
// We create a new db here to not use the default pool as we can leave it in dirty state.
t.Skip("Fails, because connection is returned to a pool dirty")
ctx := context.Background()
runID := time.Now().UnixMilli()

db := openDB(t)
defer db.Close()
db.SetMaxOpenConns(1)

conn, err := db.Conn(ctx)
if err != nil {
t.Fatal(err)
}
defer conn.Close()

dbt := DBTest{t, conn}

dbt.mustExec(forceJSON)

var dbName string
rows1 := dbt.mustQuery("SELECT CURRENT_DATABASE()")
rows1.Next()
rows1.Scan(&dbName)

newDbName := fmt.Sprintf("test_database_%v", runID)
dbt.mustExec("CREATE DATABASE " + newDbName)

rows1.Close()
conn.Close()

conn2, err := db.Conn(ctx)
if err != nil {
t.Fatal(err)
}

dbt2 := DBTest{t, conn2}

var dbName2 string
rows2 := dbt2.mustQuery("SELECT CURRENT_DATABASE()")
defer rows2.Close()
rows2.Next()
rows2.Scan(&dbName2)

if !strings.EqualFold(dbName, dbName2) {
t.Errorf("fresh connection from pool should have original database")
}
}
Loading