[WIP / DO NOT MERGE] Initial LSP implementation #1573
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
't show here
…if lsp_commands are changed the version will get updated
| from snowflake.cli.api.output.types import MessageResult | ||
| from snowflake.cli.api.project.definition_manager import DefinitionManager | ||
| from snowflake.cli.plugins.lsp.server import lsp_plugin | ||
| from snowflake.cli.plugins.nativeapp.manager import NativeAppManagern |
There was a problem hiding this comment.
Suggested change
| from snowflake.cli.plugins.nativeapp.manager import NativeAppManagern | |
| from snowflake.cli._plugins.nativeapp.manager import NativeAppManager |
| from snowflake.cli.api.cli_global_context import get_cli_context | ||
| from snowflake.cli.api.output.types import MessageResult | ||
| from snowflake.cli.api.project.definition_manager import DefinitionManager | ||
| from snowflake.cli.plugins.lsp.server import lsp_plugin |
There was a problem hiding this comment.
broken import, lsp_plugin does not exist
| raise ValueError("Expected exactly one CommandArguments object") | ||
|
|
||
| try: | ||
| args = TypeAdapter(CommandArguments).validate_python(params[0] if len(params) == 1 else {}) |
There was a problem hiding this comment.
I would explicitly handle unexpected args, at least I would log the event, silently continuing could make it very hard to debug something unexpected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
This is the initial LSP implementation that has not yet been refactored to use
fork_cli_context. It does not currently function correctly.