Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move usage telemetry to post_execute callback #1796

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Move usage telemetry to post_execute callback #1796

wants to merge 4 commits into from

Conversation

sfc-gh-turbaszek
Copy link
Contributor

@sfc-gh-turbaszek sfc-gh-turbaszek commented Oct 25, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Move telemetry sending to post execute callback to improve behavior in cases like snow connection set-default

@sfc-gh-turbaszek sfc-gh-turbaszek marked this pull request as ready for review October 25, 2024 12:46
@sfc-gh-turbaszek sfc-gh-turbaszek requested review from a team as code owners October 25, 2024 12:46
sfc-gh-melnacouzi
sfc-gh-melnacouzi reviewed Oct 29, 2024
View reviewed changes
src/snowflake/cli/api/commands/snow_typer.py

log.debug("Executing command post execution callback")
log_command_usage(execution)
Copy link
Contributor

@sfc-gh-melnacouzi sfc-gh-melnacouzi Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean that commands that do not require connection will not be part of telemetry anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-melnacouzi sfc-gh-melnacouzi sfc-gh-melnacouzi left review comments

@sfc-gh-fcampbell sfc-gh-fcampbell sfc-gh-fcampbell approved these changes

@sfc-gh-pjob sfc-gh-pjob sfc-gh-pjob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-turbaszek @sfc-gh-pjob @sfc-gh-melnacouzi @sfc-gh-fcampbell