Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1516075: use SQLALchemy 2.0 as default dependency #511

Merged
merged 5 commits into from
Jul 3, 2024
Merged

SNOW-1516075: use SQLALchemy 2.0 as default dependency #511

merged 5 commits into from
Jul 3, 2024

Conversation

sfc-gh-mraba
Copy link
Collaborator

@sfc-gh-mraba sfc-gh-mraba commented Jul 2, 2024 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    SNOW-1516075

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
    • I am updating project configuration

  3. Please describe how your code solves the related issue.

Use SQLAlchemy 2.0 as default dependency.
SQLAlchemy 1.4 moved as extra dependency for test cases and checks.

@sfc-gh-mraba sfc-gh-mraba self-assigned this Jul 2, 2024
@sfc-gh-mraba sfc-gh-mraba requested a review from a team as a code owner July 2, 2024 13:55
@sfc-gh-mraba sfc-gh-mraba enabled auto-merge (squash) July 3, 2024 12:17
@sfc-gh-mraba sfc-gh-mraba enabled auto-merge (squash) July 3, 2024 12:17
@sfc-gh-mraba sfc-gh-mraba enabled auto-merge (squash) July 3, 2024 12:21
@sfc-gh-mraba sfc-gh-mraba merged commit 423b8c1 into main Jul 3, 2024
46 checks passed
@sfc-gh-mraba sfc-gh-mraba deleted the SNOW-1516075-sqlalchemy-20-as-default branch July 3, 2024 12:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

Assignees

@sfc-gh-mraba sfc-gh-mraba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mraba @sfc-gh-astus