Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readme typos #548

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Fix readme typos #548

merged 3 commits into from
Nov 25, 2024

Conversation

sfc-gh-jvasquezrojas
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

Fixies typos in readme
Co-authored by @rosner and @aholten

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas marked this pull request as ready for review November 21, 2024 18:27
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas requested a review from a team as a code owner November 21, 2024 18:27
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas force-pushed the fix-readme-typos branch 3 times, most recently from 41faf1c to 59b4992 Compare November 22, 2024 00:54
rosner and others added 2 commits November 21, 2024 18:56
@rosner @sfc-gh-jvasquezrojas
Typo
b739752
@aholten @sfc-gh-jvasquezrojas
Fix typo in README.md
79ed0a3 
engine.connext() -> engine.connect()
auto-merge was automatically disabled November 22, 2024 14:54

Pull Request is not mergeable

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas merged commit 9b2c6d1 into main Nov 25, 2024
45 of 46 checks passed
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas deleted the fix-readme-typos branch November 25, 2024 13:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-lcalderonachio sfc-gh-lcalderonachio sfc-gh-lcalderonachio approved these changes

@sfc-gh-osalazarlizano sfc-gh-osalazarlizano sfc-gh-osalazarlizano approved these changes

@sfc-gh-ecuberojimenez sfc-gh-ecuberojimenez sfc-gh-ecuberojimenez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sfc-gh-jvasquezrojas @sfc-gh-ecuberojimenez @sfc-gh-osalazarlizano @sfc-gh-lcalderonachio @rosner @aholten