Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowchart window GUIerror Causing StackOverflow FIX in Unity 2021 #1053

Merged
merged 3 commits into from
May 14, 2022

Conversation

breadnone
Copy link
Contributor

@breadnone breadnone commented Apr 26, 2022

Description

Quick fix for the Flowchart editor window for Unity 2021 as reported by some users in #1052

What is the current behavior?

Will throw GUI Error: Invalid GUILayout state in FlowchartWindow view, and will cause StackOverflow randomly.

Important Notes

  • My change does not require modifcations or additions to documentation

EDIT: Description & Title

EDIT 2: Reverted unrelated commit!

@breadnone breadnone changed the title Flowchart window fix Flowchart window GUIerror Causing StackOverflow FIX in Unity 2021 Apr 26, 2022
@stevehalliwell
Copy link
Collaborator

I'll confirm the fix across supported unity versions, then squash merge. Might need to cherrypick across to master to make a bugfix build too.

P.S. try a rebase to drop the undesired commit rather than having to make another commit in the chain that undoes a previous one.

@breadnone
Copy link
Contributor Author

breadnone commented May 1, 2022

I'm afraid I'll mess up something if I rebased this tbh -__- , either way, it's a one-liner fix (thus, mentioned as quick fix), I'll consider closing this and make a new pr instead.

@stevehalliwell stevehalliwell merged commit 8c218d3 into snozbot:develop May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants