Fixup direct sbot usage #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of #104: identifying all direct usage of sbot. Some of that usage is easy to refactor right away, such as cases where `sbot.id` is used to get the feed id for the running user. Patchfox has always exposed the feed id as `ssb.feed`, it was just a matter of using it.
* Added `ssb.system.*` namespace. It will be used for SSB workflow stuff such as joining pubs and rooms, inspecting peers. Mostly stuff that goes into the system package.
Removed direct access to `sbot` to join pubs. Refactored to use `ssb.system.acceptInvite()` instead. This relates to #104
Related to #104 - removing direct sbot access. The system package has been refactored to use the new functions exposed by `ssb.system.*`.
Related to #104
Related to #104
Related to #104 * Refactored to use `ssb.addBlob`. * Fixed bug with cover display.
Related to #104 Refactored to use `ssb.addBlob`. Fixed small bugs.
Fucking editor I was using previously sprinkled bad indentation and semicolons all over the place, and I never spent the necessary time to fix them all. I'm doing it file by file now.
This adds `ssb.friendship.*` which contains functions to help querying for following, followers, and friends of a feed.
* Refactored to use `ssb.friendship.*` instead of `sbot.links`. * Related to #104
closes #106 This allows package developers to create branching code to support different SSB server types.
Related to #104
Related to #104
Related to #104
Each package needs to declare which platforms they suppport. This value needs to match the running server type. * `pkg.supportedPlatforms = ["nodejs-ssb"]` * `ssb.serverType = "nodejs-ssb" All packages patched to include this property. closes #106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sbotaccess in packages #104 Removes directsbotcalls where possible.platforms/nodejs-ssb#105 Renamed platform tonodejs-ssb.