Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interpolation] Add BaseBeamInterpolation class to gather all methods linked to interpolation #147

Merged
merged 12 commits into from
May 27, 2024

Conversation

epernod
Copy link
Contributor

@epernod epernod commented May 6, 2024

  1. Move all methods linked to interpolation from BeamInterpolation into BaseBeamInterpolation class.
  2. Make BeamInterpolation inherite from BaseBeamInterpolation.
  3. And make also WireBeamInterpolation inheriting from BaseBeamInterpolation.

This avoid multiple physical parameters entry between BeamInterpolation and the mechanism of WireRestShape + RodSection.

Now, to simulate:

  • A fixed Beam, you should use: BeamInterpolation and set the geometry and material properties directly inside this component.
  • For adaptiveBeam, you should use WireBeamInterpolation and set all geometry and material properties into each RodSection set in the WireRestShape

This PR only move code and change some inheritance and pointer type. Big cleaning into the code will come in next PRs

@epernod epernod added pr: clean pr: status to review To notify reviewers to review this pull-request labels May 6, 2024
@fredroy fredroy merged commit a56bde0 into sofa-framework:master May 27, 2024
4 checks passed
@epernod epernod deleted the add_baseBeamInterpolation branch July 16, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean pr: status to review To notify reviewers to review this pull-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants