(fix:pd) become a leader before the addLeaderStateListener #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ye-xiaowei, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
sofastack-cla
bot
added
bug
|
@ye-xiaowei 非常感谢，你能签一下 CLA 吗？ |
|
嗯嗯，我以为登录一下就好了 |
现在的状态是签好了吗 |
没，可能是 CLA 服务抽了，我先合并吧，非常感谢，cc @zhenjunMa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
pd 启动之后会添加一个 onLeaderStart 的回调，如果在启动之后再添加则有可能 leader 已经选举好而且调用完了 onLeaderStart。
Modification:
将添加回调代码放置在 init 之前
Result:
Fixes #1060