Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/implementation smell #1097

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Refactor/implementation smell #1097

wants to merge 5 commits into from

Commits on Mar 29, 2024

  1. refactor: Complex Condition in run method Package:com.alipay.sofa.jra… 

    …ft.rhea.client.failover.impl Class:FailoverClosureImpl
    @JAYDIPSINH27
    JAYDIPSINH27 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    abc9cdd View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. Refactor: Introduce explaining variable to make code logic more reada… 

    …ble.
    @JAYDIPSINH27
    JAYDIPSINH27 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    39c185e View commit details
    Browse the repository at this point in the history

  2. Refactor: 

    Extract Method to improve code readability.
Method had Cyclomatic complexity: 12
    @JAYDIPSINH27
    JAYDIPSINH27 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    70f514d View commit details
    Browse the repository at this point in the history

  3. Refactor: 

    Rename Method name to more readable and understandable name.
    @JAYDIPSINH27
    JAYDIPSINH27 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    637409d View commit details
    Browse the repository at this point in the history

  4. cleanup

    @JAYDIPSINH27
    JAYDIPSINH27 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    d726f77 View commit details
    Browse the repository at this point in the history