fix: unit test

sofastack · Sep 28, 2023 · 8b14d26 · 8b14d26
1 parent e15a1de
commit 8b14d26
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/module-controller/internal/controller/moduledeployment_controller.go b/module-controller/internal/controller/moduledeployment_controller.go
@@ -136,12 +136,11 @@ func (r *ModuleDeploymentReconciler) Reconcile(ctx context.Context, req ctrl.Req
 				return ctrl.Result{}, err
 			}
 		}
-
-		if !moduleVersionChanged && isUrlChange(moduleDeployment.Spec.Template.Spec.Module, newRS.Spec.Template.Spec.Module) {
-			newRS.Spec.Template.Spec.Module = moduleDeployment.Spec.Template.Spec.Module
-			if err := r.Client.Update(ctx, newRS); err != nil {
-				return ctrl.Result{}, err
-			}
+	}
+	if !moduleVersionChanged && isUrlChange(moduleDeployment.Spec.Template.Spec.Module, newRS.Spec.Template.Spec.Module) {
+		newRS.Spec.Template.Spec.Module = moduleDeployment.Spec.Template.Spec.Module
+		if err := r.Client.Update(ctx, newRS); err != nil {
+			return ctrl.Result{}, err
 		}
 	}