Fix UrlSelect trigger value reset for non expo router projects #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kmagiera
requested changes
Dec 20, 2024
| value: string; | ||
| onValueChange: (newValue: string) => void; | ||
| recentItems: UrlItem[]; | ||
| items: UrlItem[]; | ||
| disabled?: boolean; | ||
| } | ||
|
|
||
| function UrlSelect({ onValueChange, recentItems, items, value, disabled }: UrlSelectProps) { | ||
| function UrlSelect({ onValueChange, recentItems, items, key, value, disabled }: UrlSelectProps) { |
There was a problem hiding this comment.
I believe that it only has been added in React 19 that you can receive key prop like this. I don't think in the current version in propagates down to the component
| @@ -35,7 +36,7 @@ function UrlSelect({ onValueChange, recentItems, items, value, disabled }: UrlSe | |||
| }; | |||
|
|
|||
| return ( | |||
| <Select.Root onValueChange={handleValueChange} value={value} disabled={disabled}> | |||
| <Select.Root onValueChange={handleValueChange} key={key} value={value} disabled={disabled}> | |||
There was a problem hiding this comment.
It should be enough to do something along these lines, instead of having the whole logic for urlSelectKey in the parent component:
<Select.root key={value ? "has-value : "no-value"}>| @@ -117,8 +130,9 @@ function UrlBar({ disabled }: { disabled?: boolean }) { | |||
| }} | |||
| recentItems={recentUrlList} | |||
| items={sortedUrlList} | |||
| value={urlList[0]?.id} | |||
| disabled={disabledAlsoWhenStarting || urlList.length < 2} | |||
| key={urlSelectKey} | |||
There was a problem hiding this comment.
setting this here is enough to re-mount the whole component. It doesn't have to be accessed in the underlying component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the UrlBar behaviour in projects not using Expo Router navigation.
When the user intends to close the preview by pressing the goHome button (or reload), the UrlSelect's trigger value needs to be reset to a placeholder ("/").
In this solution it is achieved by using the
urlSelectKeyandurlSelectValuestates to force a full re-render of the Radix Select when the key changes.Additionally, this update disables the
goBackbutton for projects that do not use Expo Router.How Has This Been Tested:
Screen.Recording.2024-12-20.at.18.45.00.mov
Screen.Recording.2024-12-20.at.18.35.50.mov