Add themes support #874
Add themes support #874
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Hello, thank you for your time.
In general I really like the changes unfortunately there are some parts of the application that lose on readability after the changes, for example lunchConfiguration:
Vscode has styled inputs:
so i believe you can find the styles for them
I also left one inline question
Thank u again and merry Christmas
| } | ||
|
|
||
| .icon-button:active { | ||
| color: var(--swm-button-active); | ||
| background-color: var(--swm-button-active-background); | ||
| color: var(--vscode-list-activeSelectionForeground); |
There was a problem hiding this comment.
Why did you make a decision to sometimes expose the vscode variables in webview files and sometimes use swm aliases?
There was a problem hiding this comment.
@filip131311 no reason I will move it to swm variable, I think that keeping the brand variables would make more sense and easier to keep and adjust based on something maybe high contrast or so.
Thanks for the review merry Christmas 🎄 |
kewinzaq1
force-pushed
the
add-vscode-themes-support
branch
from
a0aecc9 to
49a999c
Compare
This pull request adds support for vscode themes
Connected (#729 (comment) , #866)
My approach is to use vscode theme variables that fit for ide elements.
This is an early stage draft and suggestions are more than welcome.
night-owl.mov
cursor-default.mov
vscode-default.mov
palenight.mov