Refactor screen recording and add key bindings #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This PR adds screenshot functionality introduced to the simulator server in software-mansion-labs/simulator-server@d86dcc5 ### How Has This Been Tested: run the project and make a screenshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add screenshot functionality, keybindings for capturing replays, starting an capturing the recording and capturing screenshots.
To achieve that we moved the logic for starting and ending recording from webview to the extension code.
the proposed keybindings are:
fix #868
How Has This Been Tested:
MAX_RECORDING_TIME_SECto 10 and check if the logic for closing stoping worksScreen.Recording.2024-12-23.at.17.12.46.mov