Skip to content

Commit

Permalink
Workaround for V8EXECUTOR_LIB NOTFOUND error in worklets CMakeLists.t…
Browse files Browse the repository at this point in the history
…xt (#6603)

Using v8 javascript engine was causing react-native-reanimated gradle
build to fail:
#3570

Changing the `V8_SO_DIR` according to the recommendation from @reinismu
fixes this:
Kudo/react-native-v8#208 (comment)

<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

Fixes #3570

## Test plan

I'm not sure how the current CI is passing
(#3570 (comment)),
but that would be the way to test it.

---------

Co-authored-by: Tomasz Żelawski <[email protected]>
  • Loading branch information
dlee and tjzel committed Dec 13, 2024
1 parent 886f40e commit 1160db0
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ elseif(${JS_RUNTIME} STREQUAL "v8")
PRIVATE
"${JS_RUNTIME_DIR}/src"
)
file(GLOB V8_SO_DIR "${JS_RUNTIME_DIR}/android/build/intermediates/library_jni/*/jni/${ANDROID_ABI}")
file(GLOB V8_SO_DIR "${JS_RUNTIME_DIR}/android/build/intermediates/library_jni/**/jni/${ANDROID_ABI}")
find_library(
V8EXECUTOR_LIB
v8executor
Expand Down

0 comments on commit 1160db0

Please sign in to comment.