add missing functionality

softwareconstruction240 · Nov 23, 2024 · e031d03 · e031d03
1 parent 8cb281b
commit e031d03
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/main/java/edu/byu/cs/autograder/score/Scorer.java b/src/main/java/edu/byu/cs/autograder/score/Scorer.java
@@ -318,9 +318,11 @@ private Rubric.Results mergeResultsWithPrevious(Rubric.RubricType rubricType, Ru
         float score = startingScore;
 
         for (Submission previousSubmission : previousSubmissions) {
-            Rubric.RubricItem previousItem = previousSubmission.rubric().items().get(rubricType);
-            if (previousItem != null && previousItem.results().rawScore() <= results.rawScore()) {
-                score = Math.max(score, previousItem.results().score());
+            if(previousSubmission.passed()) {
+                Rubric.RubricItem previousItem = previousSubmission.rubric().items().get(rubricType);
+                if (previousItem != null && previousItem.results().rawScore() <= results.rawScore()) {
+                    score = Math.max(score, previousItem.results().score());
+                }
             }
         }