Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

126 use full date times for dates #155

Merged
merged 3 commits into from
Feb 10, 2024
Merged

126 use full date times for dates #155

merged 3 commits into from
Feb 10, 2024

Conversation

frozenfrank
Copy link
Contributor

@frozenfrank frozenfrank commented Feb 8, 2024

This PR resolves #126 and also improves the quality of the code in the area directly related to that issue.

Please run and test my code before merging since I don't have a way to run the code locally.

@frozenfrank frozenfrank added the enhancement New feature or request label Feb 8, 2024
@frozenfrank frozenfrank requested a review from pawlh February 8, 2024 17:10
Copy link
Collaborator

@pawlh pawlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's either put back the 11:59:59 pm rule, or wait to merge this until we have confirmed that Canvas is how the professors want it

@frozenfrank
Copy link
Contributor Author

@pawlh Since you aren't actually "requesting changes," can you comment or approve the PR? There is a distinction between having the PR "approved" and actually merging it in to main.

I'm on board with waiting until Canvas is updated before we merge the code as evidenced by this Slack Message.

@pawlh
Copy link
Collaborator

pawlh commented Feb 9, 2024

@pawlh Since you aren't actually "requesting changes," can you comment or approve the PR? There is a distinction between having the PR "approved" and actually merging it in to main.

I'm on board with waiting until Canvas is updated before we merge the code as evidenced by this Slack Message.

I'd argue that this was an appropriate use of requesting changes. In this case there were two options for changes, and action needed to be taken on one of them before I would be comfortable approving anything for merging:

  1. Remove the problematic lines of code
  2. Change the environment (Canvas)

Until a change was made this code would cause an undesired result. In a CI/CD situation (which I desperately wish was being used here) the main branch and the production environment are closely connected. Still, I'll admit that this was probably an uncommon usage of the "Request Changes" feature

Either way, action was taken and my concern is mitigated, so I'll approve this now. Thanks for doing this!

@pawlh pawlh merged commit b22a89c into softwareconstruction240:main Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backend: use full datetime for due dates
2 participants